annotate components/sms @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents ad7f986afae3
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
160
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building sms.lib from the TCS3.2 source
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-me -mt -o -pw2 -x -mw"
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 CPPFLAGS=
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 make_version sms
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 cfile_plain sms_version.c
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 # Defines
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 CPPFLAGS=-DCCDTABLES_EXTERN
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -DOPTION_MULTITHREAD"
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -DNEW_FRAME"
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -DNEW_ENTITY"
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -D_TARGET_"
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -DSHARED_VSI"
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -DALR"
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -DFF_HOMEZONE"
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -DFF_MMI_SAT_ICON"
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -DFF_MMI_SMS_DYNAMIC"
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -DFF_CPHS"
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -D_TMS470"
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -DUART"
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 CPPFLAGS="$CPPFLAGS -DFF_ATI"
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 CPPFLAGS="$CPPFLAGS -DNWARN"
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 CPPFLAGS="$CPPFLAGS -DFF_EM_MODE"
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 CPPFLAGS="$CPPFLAGS -DPHONEBOOK_EXTENSION"
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 if [ "$GPRS" = 1 ]
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 then
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 CPPFLAGS="$CPPFLAGS -DGPRS"
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 fi
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 CPPFLAGS="$CPPFLAGS -DMMI=$MMI"
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 if [ "$MMI" = 0 ]
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37 then
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 CPPFLAGS="$CPPFLAGS -DACI"
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 elif [ "$MMI" = 2 ]
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 then
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 CPPFLAGS="$CPPFLAGS -DMFW"
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42 fi
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 CPPFLAGS="$CPPFLAGS -DSIM_TOOLKIT"
482
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 160
diff changeset
45 CPPFLAGS="$CPPFLAGS -DCHIPSET=$CHIPSET"
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 160
diff changeset
46 CPPFLAGS="$CPPFLAGS -DBOARD=41"
160
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48 # Includes
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
50 SRCDIR=$SRC/g23m-gsm/sms
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
51
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
52 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/inc"
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/include"
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55 CPPFLAGS="$CPPFLAGS -I../../$CDGINC"
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
56 CPPFLAGS="$CPPFLAGS -I$SRCDIR"
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
57 CPPFLAGS="$CPPFLAGS -I.."
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
58 CPPFLAGS="$CPPFLAGS -I../config"
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
59
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
60 # Source modules
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
61
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
62 cfile_str2ind $SRCDIR/sms_cp.c
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
63 cfile_str2ind $SRCDIR/sms_csf.c
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
64 cfile_str2ind $SRCDIR/sms_for.c
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
65 cfile_str2ind $SRCDIR/sms_pei.c
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
66 cfile_str2ind $SRCDIR/sms_rl.c
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
67 cfile_str2ind $SRCDIR/sms_time.c
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
68 cfile_str2ind $SRCDIR/sms_tlf.c
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
69 cfile_str2ind $SRCDIR/sms_tlp.c
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
70 cfile_str2ind $SRCDIR/sms_tls.c
40a4089bb29f sms.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
71 cfile_str2ind $SRCDIR/sms_em.c