annotate components/spi_drv @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 7c668a4acc42
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
50
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building spi_drv.lib
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-mn -mt -mw -me -pw2"
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 CPPFLAGS="-DTOOL_CHOICE=0 -D_TMS470"
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 # Includes
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app"
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 CPPFLAGS="$CPPFLAGS -I$SRC/cs/os/nucleus"
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 CPPFLAGS="$CPPFLAGS -I.."
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 CPPFLAGS="$CPPFLAGS -I../config"
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/frame/cust_os"
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -I$SRC/cs/system"
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera"
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera/rv"
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core"
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/abb"
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/armio"
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/clkm"
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/conf"
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dma"
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dsp_dwnld"
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/inth"
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/memif"
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/rhea"
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/security"
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/spi"
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/timer"
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/uart"
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/ulpd"
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 CPPFLAGS="$CPPFLAGS -I$SRC/cs/services"
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 # Source modules
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 SRCDIR=$SRC/cs/drivers/drv_app/spi
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 cfile_plain $SRCDIR/spi_process.c
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 cfile_plain $SRCDIR/spi_api.c
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 cfile_plain $SRCDIR/spi_env.c
7c668a4acc42 spi_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 cfile_plain $SRCDIR/spi_task.c