annotate components/t30 @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents ad7f986afae3
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
180
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building t30.lib from the TCS3.2 source
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-me -mt -o -pw2 -x -mw"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 CPPFLAGS=
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 make_version t30
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 cfile_plain t30_version.c
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 # Defines
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 CPPFLAGS=-DCCDTABLES_EXTERN
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -DOPTION_MULTITHREAD"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -DNEW_FRAME"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -DNEW_ENTITY"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -D_TARGET_"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -DSHARED_VSI"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -DALR"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -DFF_HOMEZONE"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -DFF_MMI_SAT_ICON"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -DFF_MMI_SMS_DYNAMIC"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -DFF_CPHS"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -D_TMS470"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -DUART"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 CPPFLAGS="$CPPFLAGS -DFF_ATI"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 CPPFLAGS="$CPPFLAGS -DNWARN"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 CPPFLAGS="$CPPFLAGS -DFF_EM_MODE"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 CPPFLAGS="$CPPFLAGS -DAT_INTERPRETER"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 CPPFLAGS="$CPPFLAGS -DUSE_L1FD_FUNC_INTERFACE"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 CPPFLAGS="$CPPFLAGS -DFAX_AND_DATA"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 CPPFLAGS="$CPPFLAGS -DFF_FAX"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 CPPFLAGS="$CPPFLAGS -DUSE_L2FD_FUNC_INTERFACE"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 CPPFLAGS="$CPPFLAGS -DSRVC=1"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 CPPFLAGS="$CPPFLAGS -DMMI=$MMI"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 if [ "$MMI" = 0 ]
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 then
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37 CPPFLAGS="$CPPFLAGS -DACI"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 elif [ "$MMI" = 2 ]
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 then
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 CPPFLAGS="$CPPFLAGS -DMFW"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 fi
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 CPPFLAGS="$CPPFLAGS -DPHONEBOOK_EXTENSION"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 if [ "$GPRS" = 1 ]
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46 then
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47 CPPFLAGS="$CPPFLAGS -DGPRS"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48 fi
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
50 CPPFLAGS="$CPPFLAGS -DDTI2"
482
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 180
diff changeset
51 CPPFLAGS="$CPPFLAGS -DCHIPSET=$CHIPSET"
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 180
diff changeset
52 CPPFLAGS="$CPPFLAGS -DBOARD=41"
180
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54 # Includes
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
56 SRCDIR=$SRC/g23m-fad/t30
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
57
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
58 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/inc"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
59 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
60 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/include"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
61 CPPFLAGS="$CPPFLAGS -I../../$CDGINC"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
62 CPPFLAGS="$CPPFLAGS -I$SRCDIR"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
63 CPPFLAGS="$CPPFLAGS -I.."
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
64 CPPFLAGS="$CPPFLAGS -I../config"
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
65
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
66 # Source modules
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
67
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
68 cfile_str2ind $SRCDIR/t30_bcsf.c
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
69 cfile_str2ind $SRCDIR/t30_bcss.c
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
70 cfile_str2ind $SRCDIR/t30_kerf.c
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
71 cfile_str2ind $SRCDIR/t30_kerp.c
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
72 cfile_str2ind $SRCDIR/t30_kers.c
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
73 cfile_str2ind $SRCDIR/t30_msgs.c
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
74 cfile_str2ind $SRCDIR/t30_muxp.c
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
75 cfile_str2ind $SRCDIR/t30_muxs.c
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
76 cfile_str2ind $SRCDIR/t30_pei.c
24955aef4da3 t30.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
77 cfile_str2ind $SRCDIR/t30_tim.c