annotate components/tif_na7_db_fl @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 597eb715a541
children 9f191ca0051f
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
299
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building tif_na7_db_fl.lib using the GPF source bits we got with TCS211
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-mw -x -pw2 -o -me -mt -g -mn"
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 # Defines
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 CPPFLAGS="-DNU_DEBUG -DRUN_FLASH"
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 CPPFLAGS="$CPPFLAGS -D_TARGET_ -D_NUCLEUS_"
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 # Includes
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc/nuc"
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc/nuc/arm7"
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/frame"
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/ccd"
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -I$SRC/gpf2/tst"
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -I$SRC/cs/system"
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera"
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera/rvt"
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core"
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/uart"
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app"
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app/uart"
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 CPPFLAGS="$CPPFLAGS -I$SRC/cs/services"
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 CPPFLAGS="$CPPFLAGS -I.."
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 CPPFLAGS="$CPPFLAGS -I../config"
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 # Source modules
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 SRCDIR=$SRC/gpf2/tst
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 cfile_plain $SRCDIR/drv/tr2.c
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 cfile_plain $SRCDIR/drv/tif2.c
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 cfile_plain $SRCDIR/drv/ser_tr.c
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 cfile_plain $SRCDIR/drv/titrc.c
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37 cfile_plain $SRCDIR/tst_pei.c
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 cfile_plain $SRCDIR/tstdriver.c
597eb715a541 components/tif_na7_db_fl: recompilation successful, matches original blob lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 cfile_plain $SRCDIR/tif_version.c