annotate configs/hybrid-vpm @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents fe200bd2f188
children 69e52afc01d5
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
355
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # This is the "voice pseudo-modem" configuration:
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 # no phone UI, but no data services either
368
6a753424d524 configs/hybrid-vpm: FCHG enabled
Mychaela Falconia <falcon@freecalypso.org>
parents: 355
diff changeset
3 # battery management (FCHG) is enabled
355
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
394
fe200bd2f188 configs/*: converted to use scripts/config-headers-new.sh
Mychaela Falconia <falcon@freecalypso.org>
parents: 368
diff changeset
5 GPRS=0
fe200bd2f188 configs/*: converted to use scripts/config-headers-new.sh
Mychaela Falconia <falcon@freecalypso.org>
parents: 368
diff changeset
6 MMI=0
fe200bd2f188 configs/*: converted to use scripts/config-headers-new.sh
Mychaela Falconia <falcon@freecalypso.org>
parents: 368
diff changeset
7 SRVC=0
fe200bd2f188 configs/*: converted to use scripts/config-headers-new.sh
Mychaela Falconia <falcon@freecalypso.org>
parents: 368
diff changeset
8 export GPRS MMI SRVC
fe200bd2f188 configs/*: converted to use scripts/config-headers-new.sh
Mychaela Falconia <falcon@freecalypso.org>
parents: 368
diff changeset
9
fe200bd2f188 configs/*: converted to use scripts/config-headers-new.sh
Mychaela Falconia <falcon@freecalypso.org>
parents: 368
diff changeset
10 ATP_STATE=0
fe200bd2f188 configs/*: converted to use scripts/config-headers-new.sh
Mychaela Falconia <falcon@freecalypso.org>
parents: 368
diff changeset
11 FCHG_STATE=1
fe200bd2f188 configs/*: converted to use scripts/config-headers-new.sh
Mychaela Falconia <falcon@freecalypso.org>
parents: 368
diff changeset
12 LCC_STATE=0
fe200bd2f188 configs/*: converted to use scripts/config-headers-new.sh
Mychaela Falconia <falcon@freecalypso.org>
parents: 368
diff changeset
13 MKS_STATE=0
fe200bd2f188 configs/*: converted to use scripts/config-headers-new.sh
Mychaela Falconia <falcon@freecalypso.org>
parents: 368
diff changeset
14 PWR_STATE=0
fe200bd2f188 configs/*: converted to use scripts/config-headers-new.sh
Mychaela Falconia <falcon@freecalypso.org>
parents: 368
diff changeset
15 R2D_STATE=0
fe200bd2f188 configs/*: converted to use scripts/config-headers-new.sh
Mychaela Falconia <falcon@freecalypso.org>
parents: 368
diff changeset
16 export ATP_STATE FCHG_STATE LCC_STATE MKS_STATE PWR_STATE R2D_STATE
fe200bd2f188 configs/*: converted to use scripts/config-headers-new.sh
Mychaela Falconia <falcon@freecalypso.org>
parents: 368
diff changeset
17
fe200bd2f188 configs/*: converted to use scripts/config-headers-new.sh
Mychaela Falconia <falcon@freecalypso.org>
parents: 368
diff changeset
18 scripts/config-headers-new.sh
355
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CONDAT=condat3
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 GPF=gpf3
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CDGINC=cdg-hybrid/cdginc
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CDGPRIM=cdg-hybrid/sap-inline
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 ACI=g23m-aci
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 export CONDAT GPF CDGINC CDGPRIM ACI
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 build_lib ccddata
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 # ACI libs
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 build_lib aci tcs3
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 build_lib aciext tcs3
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 build_lib aci_dti_mng tcs3
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 build_lib atiext tcs3
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 build_lib comlib hybrid
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 build_lib config_gsm_fl
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 build_lib config_gsm_ir
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37 lib_link_magic '(BSS_LIBS (.bss) CONST_LIBS (.text, .const))'
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 # G23M protocol stack libs
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 build_lib alr sotovik
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 build_lib cc
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42 build_lib dl
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 build_lib dti
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 build_lib l1_pei
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 build_lib mm
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46 build_lib rr
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47 build_lib sim_b_lib
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48 build_lib sms
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49 build_lib ss
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
50 build_lib uart_b_lib
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
51
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
52 # Condat drivers
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53 build_lib gdi
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55 # GPF
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
56 build_lib ccd_na7_db
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
57 blob_lib_gpf frame_na7_db_fl
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
58 blob_lib_custom blobs/patches/frame_na7_db_ir-systrace.lib frame_na7_db_ir
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
59 lib_link_magic '(BSS_LIBS (.bss) CONST_LIBS (.text, .const))'
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
60 blob_lib_gpf misc_na7_db_fl
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
61 blob_lib_gpf misc_na7_db_ir
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
62 lib_link_magic '(BSS_LIBS (.bss) CONST_LIBS (.text, .const))'
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
63 blob_lib_gpf osx_na7_db
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
64 lib_link_magic '(BSS_LIBS (.bss) CONST_LIBS (.text, .const))'
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
65 blob_lib_gpf tif_na7_db_fl
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
66 blob_lib_gpf tif_na7_db_ir
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
67 lib_link_magic '(BSS_LIBS (.bss) CONST_LIBS (.text, .const))'
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
68
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
69 # core drivers
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
70 build_lib drivers_flash
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
71
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
72 # Layer 1
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
73 build_lib tpudrv
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
74 lib_link_magic '(BSS_LIBS (.bss) CONST_LIBS (.text, .const))'
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
75 build_lib l1_ext
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
76 lib_link_magic '(BSS_LIBS (.l1s_global))'
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
77 build_lib l1_int
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
78 lib_link_magic '(BSS_LIBS (.bss) CONST_LIBS (.text, .const))'
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
79 build_lib l1_custom_ext
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
80 build_lib l1_custom_int
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
81 lib_link_magic '(BSS_LIBS (.bss) CONST_LIBS (.text, .const))'
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
82
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
83 build_lib riviera_core_flash
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
84 build_lib riviera_cust_flash
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
85
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
86 # services
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
87 #build_lib atp
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
88 build_lib audio
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
89 build_lib audio_bgd
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
90 build_lib cst
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
91 build_lib dar
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
92 build_lib dar_gbl_var
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
93 lib_link_magic '(BSS_DAR_LIB (.bss))'
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
94 build_lib etm
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
95 build_lib lls
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
96 #build_lib mks
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
97
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
98 # app drivers
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
99 build_lib abb
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
100 build_lib buzzer
368
6a753424d524 configs/hybrid-vpm: FCHG enabled
Mychaela Falconia <falcon@freecalypso.org>
parents: 355
diff changeset
101 build_lib fchg
355
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
102 build_lib ffs
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
103 build_lib ffs_drv
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
104 build_lib ffs_pcm
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
105 build_lib kpd
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
106 build_lib power
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
107 build_lib rtc_drv
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
108 build_lib sim_drv
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
109 build_lib spi_drv
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
110 build_lib uart_drv
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
111
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
112 # system glue
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
113 build_lib main init
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
114 build_lib bootloader
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
115 lib_link_magic '(CONST_BOOT_LIB (.const, .text, .text:v$3) BSS_BOOT_LIB (.bss))'
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
116
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
117 # Nucleus and TI's compiler stuff
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
118 blob_lib_os nucleus_flash_nodbg
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
119 blob_lib_os nucleus_int_ram_nodbg
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
120 lib_link_magic '(BSS_LIBS (.bss) CONST_LIBS (.text, .const))'
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
121 blob_lib_os rts16le_flash
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
122 blob_lib_os rts16le_int_ram
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
123 lib_link_magic '(BSS_LIBS (.bss))'
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
124
dc95795a34a9 configs/hybrid-vpm: created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
125 str2ind_blobs_used=0