annotate helpers/Makefile @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents b8b08c302ace
children a490b0466fed
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
9
05945a9b9dda makeline helper written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 CC= gcc
05945a9b9dda makeline helper written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 CFLAGS= -O2
388
b8b08c302ace cfg-hdr-gen C helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents: 257
diff changeset
3 PROGS= build-date cfg-hdr-gen makeline mk-flash-script srec4ram str2ind-ver
9
05945a9b9dda makeline helper written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
05945a9b9dda makeline helper written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 all: ${PROGS}
05945a9b9dda makeline helper written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
248
35b17d54773d helpers: build-date helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents: 92
diff changeset
7 build-date: build-date.c
35b17d54773d helpers: build-date helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents: 92
diff changeset
8 ${CC} ${CFLAGS} -o $@ $@.c
35b17d54773d helpers: build-date helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents: 92
diff changeset
9
388
b8b08c302ace cfg-hdr-gen C helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents: 257
diff changeset
10 cfg-hdr-gen: cfg-hdr-gen.c
b8b08c302ace cfg-hdr-gen C helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents: 257
diff changeset
11 ${CC} ${CFLAGS} -o $@ $@.c
b8b08c302ace cfg-hdr-gen C helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents: 257
diff changeset
12
9
05945a9b9dda makeline helper written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 makeline: makeline.c
05945a9b9dda makeline helper written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 ${CC} ${CFLAGS} -o $@ $@.c
05945a9b9dda makeline helper written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15
257
d4d07c751e56 helpers: mk-flash-script helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents: 248
diff changeset
16 mk-flash-script: mk-flash-script.c
d4d07c751e56 helpers: mk-flash-script helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents: 248
diff changeset
17 ${CC} ${CFLAGS} -o $@ $@.c
d4d07c751e56 helpers: mk-flash-script helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents: 248
diff changeset
18
92
40b08f6cb2b8 srec4ram helper utility written
Mychaela Falconia <falcon@freecalypso.org>
parents: 60
diff changeset
19 srec4ram: srec4ram.c
40b08f6cb2b8 srec4ram helper utility written
Mychaela Falconia <falcon@freecalypso.org>
parents: 60
diff changeset
20 ${CC} ${CFLAGS} -o $@ $@.c
40b08f6cb2b8 srec4ram helper utility written
Mychaela Falconia <falcon@freecalypso.org>
parents: 60
diff changeset
21
60
f4eeab478bfe str2ind-ver helper written
Mychaela Falconia <falcon@freecalypso.org>
parents: 9
diff changeset
22 str2ind-ver: str2ind-ver.c
f4eeab478bfe str2ind-ver helper written
Mychaela Falconia <falcon@freecalypso.org>
parents: 9
diff changeset
23 ${CC} ${CFLAGS} -o $@ $@.c
f4eeab478bfe str2ind-ver helper written
Mychaela Falconia <falcon@freecalypso.org>
parents: 9
diff changeset
24
9
05945a9b9dda makeline helper written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 clean:
05945a9b9dda makeline helper written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 rm -f ${PROGS}