FreeCalypso > hg > fc-magnetite
annotate helpers/build-date.c @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 22 Jul 2018 06:04:49 +0000 |
parents | 35b17d54773d |
children | 074e24776948 |
rev | line source |
---|---|
248
35b17d54773d
helpers: build-date helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
1 /* |
35b17d54773d
helpers: build-date helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
2 * This program runs at firmware build time to produce a C file for the |
35b17d54773d
helpers: build-date helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
3 * fw build that includes the build date and time stamp. |
35b17d54773d
helpers: build-date helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
4 */ |
35b17d54773d
helpers: build-date helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
5 |
35b17d54773d
helpers: build-date helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
6 #include <stdio.h> |
35b17d54773d
helpers: build-date helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
7 #include <stdlib.h> |
35b17d54773d
helpers: build-date helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
8 #include <time.h> |
35b17d54773d
helpers: build-date helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
9 |
35b17d54773d
helpers: build-date helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
10 main(argc, argv) |
35b17d54773d
helpers: build-date helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
11 char **argv; |
35b17d54773d
helpers: build-date helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
12 { |
35b17d54773d
helpers: build-date helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
13 time_t now; |
35b17d54773d
helpers: build-date helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
14 struct tm *tm; |
35b17d54773d
helpers: build-date helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
15 |
35b17d54773d
helpers: build-date helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
16 if (argc != 2) { |
35b17d54773d
helpers: build-date helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
17 fprintf(stderr, "usage: %s config_name\n", argv[0]); |
35b17d54773d
helpers: build-date helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
18 exit(1); |
35b17d54773d
helpers: build-date helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
19 } |
35b17d54773d
helpers: build-date helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
20 time(&now); |
35b17d54773d
helpers: build-date helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
21 tm = gmtime(&now); |
35b17d54773d
helpers: build-date helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
22 printf("const char firmware_version_str[] =\n"); |
35b17d54773d
helpers: build-date helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
23 printf("\"FreeCalypso Magnetite %s, ", argv[1]); |
35b17d54773d
helpers: build-date helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
24 printf("build date %d-%02d-%02dT%02d:%02d:%02dZ\";\n", |
35b17d54773d
helpers: build-date helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
25 tm->tm_year+1900, tm->tm_mon+1, tm->tm_mday, |
35b17d54773d
helpers: build-date helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
26 tm->tm_hour, tm->tm_min, tm->tm_sec); |
35b17d54773d
helpers: build-date helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
27 exit(0); |
35b17d54773d
helpers: build-date helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
28 } |