annotate makefile-frags/link-steps @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 9432dd63626b
children deabd7b91828
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
250
9432dd63626b firmware ident and build date mechanism implemented at the build level
Mychaela Falconia <falcon@freecalypso.org>
parents: 88
diff changeset
1 build_date.c: ${LIBS}
9432dd63626b firmware ident and build date mechanism implemented at the build level
Mychaela Falconia <falcon@freecalypso.org>
parents: 88
diff changeset
2 ../helpers/build-date ${CONFIG_NAME} > $@
9432dd63626b firmware ident and build date mechanism implemented at the build level
Mychaela Falconia <falcon@freecalypso.org>
parents: 88
diff changeset
3
9432dd63626b firmware ident and build date mechanism implemented at the build level
Mychaela Falconia <falcon@freecalypso.org>
parents: 88
diff changeset
4 build_date.obj: build_date.c
9432dd63626b firmware ident and build date mechanism implemented at the build level
Mychaela Falconia <falcon@freecalypso.org>
parents: 88
diff changeset
5 ../toolwrap/cl470 -q -c -me -mt -o -pw2 -x -mw build_date.c
9432dd63626b firmware ident and build date mechanism implemented at the build level
Mychaela Falconia <falcon@freecalypso.org>
parents: 88
diff changeset
6
61
dba3f097489e makefile-frags: initial concept
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 str2ind.obj: str2ind.c
dba3f097489e makefile-frags: initial concept
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 ../toolwrap/cl470 -q -c -me -mt -o -pw2 -x -mw str2ind.c
dba3f097489e makefile-frags: initial concept
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9
dba3f097489e makefile-frags: initial concept
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 link.cmd: ${LINK_SCRIPT_SRC} Makefile lcfgen
63
065aacae8b37 makefile-frags/link-steps: it's make_cmd.pl, not make-cmd.pl
Mychaela Falconia <falcon@freecalypso.org>
parents: 61
diff changeset
11 perl ../scripts/ti/make_cmd.pl lcfgen $@ 0 ${LINK_SCRIPT_SRC} \
61
dba3f097489e makefile-frags: initial concept
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 ${SPECIAL_LINK_LIBS}
dba3f097489e makefile-frags: initial concept
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13
250
9432dd63626b firmware ident and build date mechanism implemented at the build level
Mychaela Falconia <falcon@freecalypso.org>
parents: 88
diff changeset
14 fwimage.out: ${LIBS} build_date.obj str2ind.obj link.cmd
64
84f4a04fde24 TI's linker doesn't like hyphens in filenames
Mychaela Falconia <falcon@freecalypso.org>
parents: 63
diff changeset
15 ../toolwrap/vlnk470 -farcall -x -o $@ -m fwimage.map $^
61
dba3f097489e makefile-frags: initial concept
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16
64
84f4a04fde24 TI's linker doesn't like hyphens in filenames
Mychaela Falconia <falcon@freecalypso.org>
parents: 63
diff changeset
17 fwimage.m0: fwimage.out
84f4a04fde24 TI's linker doesn't like hyphens in filenames
Mychaela Falconia <falcon@freecalypso.org>
parents: 63
diff changeset
18 ../toolwrap/hex470 -m -memwidth 16 -romwidth 16 $<
61
dba3f097489e makefile-frags: initial concept
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19