annotate scripts/make-rv-swe-hdr.sh @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 23e9a9f18b97
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
386
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 #!/bin/sh
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 echo '#ifndef __RV_SWE_H__'
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 echo '#define __RV_SWE_H__'
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 echo
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 if [ "$ATP_STATE" = 1 ]
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 then
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 echo '#define RVM_ATP_SWE'
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 fi
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 echo '#define RVM_AUDIO_SWE'
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 echo '#define RVM_ETM_SWE'
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 echo '#define RVM_DAR_SWE'
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 echo '#define RVM_SPI_SWE'
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 echo '#define RVM_LLS_SWE'
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 echo '#define RVM_KPD_SWE'
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 if [ "$FCHG_STATE" = 1 ]
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 then
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 echo '#define RVM_FCHG_SWE'
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 fi
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 if [ "$LCC_STATE" = 1 ]
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 then
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 echo '#define RVM_LCC_SWE'
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 fi
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 if [ "$PWR_STATE" = 1 ]
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 then
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 echo '#define RVM_PWR_SWE'
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 fi
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 if [ "$R2D_STATE" = 1 ]
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 then
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 echo '#define RVM_R2D_SWE'
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37 fi
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 if [ "$MKS_STATE" = 1 ]
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 then
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 echo '#define RVM_MKS_SWE'
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42 fi
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 echo '#define RVM_RTC_SWE'
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 echo '#define RVM_FFS_SWE'
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47 echo
23e9a9f18b97 scripts/make-rv-swe-hdr.sh: new script for generating rv_swe.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48 echo '#endif /* __RV_SWE_H__ */'