annotate targets/c139.h @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 6c3881378a31
children ea22e20c3d70
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
89
6c3881378a31 targets: c139 and pirelli added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 #define CONFIG_TARGET_C139 1
6c3881378a31 targets: c139 and pirelli added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 #define CONFIG_TARGET_COMPAL 1
6c3881378a31 targets: c139 and pirelli added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 #define USE_TSPACT2_FOR_TXLOW 1
6c3881378a31 targets: c139 and pirelli added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 #define UARTFAX_CLASSIC_DTR_DCD 0