annotate targets/gtamodem.conf @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 13bcc2ed7e44
children 5f00e9afd5d9
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
58
a5fcfcfab736 targets/*.conf: the linker script template source is set here
Mychaela Falconia <falcon@freecalypso.org>
parents: 56
diff changeset
1 LINK_SCRIPT_SRC=src/cs/system/template/gsm_ds_k5a3281.template
56
e17c1e28389f targets/*.conf: selection of main.lib blob variants
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 MAIN_blob=blobs/libs/main.lib
101
5c13f9325e2d preparations for rebuilding main.lib from partial source
Mychaela Falconia <falcon@freecalypso.org>
parents: 66
diff changeset
3 INIT_blob=blobs/obj/main/init.obj
66
0377665aef9d tpudrv.lib blob selection in targets/*.conf
Mychaela Falconia <falcon@freecalypso.org>
parents: 58
diff changeset
4 TPUDRV_blob=blobs/libs/tpudrv.lib
258
13bcc2ed7e44 configure.sh & targets/*.conf: emit FLASH_BASE_ADDR & FLASH_SECTOR_SIZE
Mychaela Falconia <falcon@freecalypso.org>
parents: 101
diff changeset
5 FLASH_BASE_ADDR=0
13bcc2ed7e44 configure.sh & targets/*.conf: emit FLASH_BASE_ADDR & FLASH_SECTOR_SIZE
Mychaela Falconia <falcon@freecalypso.org>
parents: 101
diff changeset
6 FLASH_SECTOR_SIZE=0x10000