FFS dev.c, Leonardo target: Fujitsu MB84VF5F5F4J2 #if 0'ed out The FFS code we got from TI/Openmoko had a stanza for "Fujitsu MB84VF5F5F4J2 stacked device", using a fake device ID code that would need to be patched manually into cfgffs.c (suppressing and overriding autodetection) and using an FFS base address in the nCS2 bank, indicating that this FFS config was probably meant for the MCP version of Leonardo which allows for 16 MiB flash with a second bank on nCS2. We previously had this FFS config stanza conditionalized under CONFIG_TARGET_LEONARDO because the base address contained therein is invalid for other targets, but now that we actually have a Leonardo build target in FC Magnetite, I realize that the better approach is to #if 0 out this stanza altogether: it is already non-functional because it uses a fake device ID code, thus it is does not add support for more Leonardo board variants, instead it is just noise.

--- a/src/cs/drivers/drv_app/ffs/board/dev.c	Sun Dec 22 00:23:38 2019 +0000
+++ b/src/cs/drivers/drv_app/ffs/board/dev.c	Sun Dec 22 21:24:29 2019 +0000
@@ -126,10 +126,7 @@
   { 0x780000, 18 },
   { 0x7C0000, 18 }
 };
-#endif
 
-#if defined(CONFIG_TARGET_LEONARDO) || defined(CONFIG_TARGET_PIRELLI) || \
-	defined(CONFIG_TARGET_FCFAM)
 // 128x64kb
 static const struct block_info_s flash_128x64[] =
 {
@@ -547,7 +544,7 @@
     { &flash_16x64[0], (char *) 0x700000, MANUFACT_FUJITSU, 0x0201,
       FFS_DRIVER_AMD_SB, 15 },
 
-#ifdef CONFIG_TARGET_LEONARDO
+#if 0
     // Fujitsu MB84VF5F5F4J2 stacked device. Using the 2nd sub device
     // The 8x8 are located both in top and bottom, thus only 126
     // blocks are used.