view cdg-hybrid/cdginc/m_tst.val @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents e7a67accfad9
children
line wrap: on
line source

/*
+--------------------------------------------------------------------------+
| PROJECT : PROTOCOL STACK                                                 |
| FILE    : m_tst.val                                                      |
| SOURCE  : "msg\tst.mdf"                                                  |
| LastModified : "2000-10-23"                                              |
| IdAndVersion : "8441.603.99.005"                                         |
| SrcFileTime  : "Wed Nov 28 10:21:30 2007"                                |
| Generated by CCDGEN_2.5.5A on Fri Oct 14 21:41:52 2016                   |
|           !!DO NOT MODIFY!!DO NOT MODIFY!!DO NOT MODIFY!!                |
+--------------------------------------------------------------------------+
*/

/* PRAGMAS
 * PREFIX                 : NONE
 * COMPATIBILITY_DEFINES  : NO (require PREFIX)
 * ALWAYS_ENUM_IN_VAL_FILE: NO
 * ENABLE_GROUP: NO
 * CAPITALIZE_TYPENAME: NO
 */


#ifndef M_TST_VAL
#define M_TST_VAL


#define CDG_ENTER__M_TST_VAL

#define CDG_ENTER__FILENAME _M_TST_VAL
#define CDG_ENTER__M_TST_VAL__FILE_TYPE CDGINC
#define CDG_ENTER__M_TST_VAL__LAST_MODIFIED _2000_10_23
#define CDG_ENTER__M_TST_VAL__ID_AND_VERSION _8441_603_99_005

#define CDG_ENTER__M_TST_VAL__SRC_FILE_TIME _Wed_Nov_28_10_21_30_2007

#include "CDG_ENTER.h"

#undef CDG_ENTER__M_TST_VAL

#undef CDG_ENTER__FILENAME


/*
 * Value constants for VAL_no_of_pdus
 */
#define VAL_NO_OF_PDUS___DEF           (0x0)      /* Number of PDUs to transmit     */
#define TEST_INFINITIVE_NO             (0x0)      /* ciphering not used             */

/*
 * Value constants for VAL_dl_timeslot_offset
 */
#define TEST_TN0                       (0x0)      /* downlink timeslot offsett 0    */
#define TEST_TN1                       (0x1)      /* downlink timeslot offsett 1    */
#define TEST_TN2                       (0x2)      /* downlink timeslot offsett 2    */
#define TEST_TN3                       (0x3)      /* downlink timeslot offsett 3    */
#define TEST_TN4                       (0x4)      /* downlink timeslot offsett 4    */
#define TEST_TN5                       (0x5)      /* downlink timeslot offsett 5    */
#define TEST_TN6                       (0x6)      /* downlink timeslot offsett 6    */
#define TEST_TN7                       (0x7)      /* downlink timeslot offsett 7    */

/*
 * Value constants for VAL_mode_flag_val
 */
#define TEST_RANDOM                    (0x0)      /* pseudorandom data              */
#define TEST_LOOP                      (0x1)      /* loop back                      */

/*
 * user defined constants
 */
#define L3MAX                          (0xfb)     
#define MAX_N_PDU_NUMBER_LIST          (0xb)      

#include "CDG_LEAVE.h"


#endif