FreeCalypso > hg > fc-magnetite

view cdg-hybrid/cdginc/p_fad.val @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents e7a67accfad9
children
line wrap: on
line source

/*
+--------------------------------------------------------------------------+
| PROJECT : PROTOCOL STACK                                                 |
| FILE    : p_fad.val                                                      |
| SOURCE  : "sap\fad.pdf"                                                  |
| LastModified : "2002-04-22"                                              |
| IdAndVersion : "8411.103.00.305"                                         |
| SrcFileTime  : "Thu Nov 29 09:41:22 2007"                                |
| Generated by CCDGEN_2.5.5A on Fri Oct 14 21:41:52 2016                   |
|           !!DO NOT MODIFY!!DO NOT MODIFY!!DO NOT MODIFY!!                |
+--------------------------------------------------------------------------+
*/

/* PRAGMAS
 * PREFIX                 : NONE
 * COMPATIBILITY_DEFINES  : NO (require PREFIX)
 * ALWAYS_ENUM_IN_VAL_FILE: NO
 * ENABLE_GROUP: NO
 * CAPITALIZE_TYPENAME: NO
 */


#ifndef P_FAD_VAL
#define P_FAD_VAL


#define CDG_ENTER__P_FAD_VAL

#define CDG_ENTER__FILENAME _P_FAD_VAL
#define CDG_ENTER__P_FAD_VAL__FILE_TYPE CDGINC
#define CDG_ENTER__P_FAD_VAL__LAST_MODIFIED _2002_04_22
#define CDG_ENTER__P_FAD_VAL__ID_AND_VERSION _8411_103_00_305

#define CDG_ENTER__P_FAD_VAL__SRC_FILE_TIME _Thu_Nov_29_09_41_22_2007

#include "CDG_ENTER.h"

#undef CDG_ENTER__P_FAD_VAL

#undef CDG_ENTER__FILENAME


/*
 * Value constants for VAL_trans_rate
 */
#define R_BCS                          (0x12c)    /* rate 300 bit/s                 */
#define R_2400                         (0x960)    /* rate 2400 bit/s                */
#define R_4800                         (0x12c0)   /* rate 4800 bit/s                */
#define R_7200                         (0x1c20)   /* rate 7200 bit/s                */
#define R_9600                         (0x2580)   /* rate 9600 bit/s                */
#define R_12000                        (0x2ee0)   /* rate 12000 bit/s               */
#define R_14400                        (0x3840)   /* rate 14400 bit/s               */

/*
 * Value constants for VAL_mode
 */
#define MUX_OFF                        (0x0)      /* ignore                         */
#define MUX_BCS                        (0x1)      /* BCS data                       */
#define MUX_MSG                        (0x2)      /* MSG  data                      */

/*
 * Value constants for VAL_cause
 */
#define ERR_REM_FAD                    (0xcc00)   /* reserved                       */
#define ERR_REM_PREAMBLE               (0xcc11)   /* DATA received instead of PREAMBLE - Preamble too short */
#define ERR_REM_DATA_BCS               (0xcc12)   /* DATA received from remote modem during BCS phase */
#define ERR_REM_TRAIN_START            (0xcc13)   /* DATA received from remote modem at start of training */
#define ERR_REM_NO_TRAINING            (0xcc14)   /* DATA received from remote modem prior to training */
#define ERR_REM_TRAINING               (0xcc15)   /* DATA received from remote modem during training */
#define ERR_REM_MSG                    (0xcc16)   /* DATA received from remote modem while sending MSG data */
#define ERR_REM_PREAMBLE_SHORT         (0xcc17)   /* PREAMBLE received from remote station too short */
#define ERR_REM_PREAMBLE_LONG          (0xcc18)   /* PREAMBLE received from remote station too long */
#define ERR_REM_IDENT                  (0xcc19)   /* Incorrect identification from remote modem */
#define ERR_LOCAL_FAD                  (0xcc20)   /* reserved                       */
#define ERR_LOCAL_BCS_RATE             (0xcc21)   /* BCS rate requested by local modem (MSG phase) */
#define ERR_LOCAL_MSG_RATE             (0xcc22)   /* MSG rate requested by local modem (BCS phase) */
#define ERR_LOCAL_DATA_NULL            (0xcc23)   /* DATA request received from T30 in NULL state */
#define ERR_LOCAL_DATA_BCS             (0xcc24)   /* DATA request received from T30 while receiving BCS data */
#define ERR_LOCAL_DATA_TCF_SND         (0xcc25)   /* DATA request received from T30 while sending TCF  data */
#define ERR_LOCAL_DATA_TCF_RCV         (0xcc26)   /* DATA request received from T30 while receiving TCF  data */
#define ERR_LOCAL_DATA_MSG             (0xcc27)   /* DATA request received from T30 while receiving MSG data */
#define ERR_LOCAL_DATA_UNDEF           (0xcc28)   /* DATA request received from T30 - state unknown */
#define ERR_LOCAL_DATA_MSG_UFL         (0xcc29)   /* DATA request not received from T30 - MSG-REC underflow */
#define ERR_LOCAL_IDENT                (0xcc30)   /* Incorrect identification from local modem */
#define ERR_OWN_FAD                    (0xcc40)   /* reserved                       */
#define ERR_FAD_SUB_TRAIN              (0xcc41)   /* FAD in unknown substate during training */
#define ERR_FAD_SUB_TCF                (0xcc42)   /* FAD in unknown substate (TCF)  */
#define ERR_FAD_SUB_MSG                (0xcc43)   /* FAD in unknown substate (MSG)  */
#define ERR_GENERAL_FAD                (0xcc50)   /* reserved                       */
#define ERR_INVALID_DATA_RCV           (0xcc51)   /* invalid data received          */
#define ERR_EMPTY_BUFFER               (0xcc52)   /* send/receive buffer is empty   */
#define ERR_OVERFLOW_BCS_RCV           (0xcc52)   /* buffer  overflow while receiving BCS data */
#define ERR_NOT_SET                    (0xccff)   /* error not set                  */

/*
 * user defined constants
 */
#define DUMMY_FAD                      (0x0)      

#include "CDG_LEAVE.h"


#endif