FreeCalypso > hg > fc-magnetite
view cdg-hybrid/cdginc/p_mnss.val @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 22 Jul 2018 06:04:49 +0000 |
parents | e7a67accfad9 |
children |
line wrap: on
line source
/* +--------------------------------------------------------------------------+ | PROJECT : PROTOCOL STACK | | FILE : p_mnss.val | | SOURCE : "sap\mnss.pdf" | | LastModified : "2002-08-01" | | IdAndVersion : "6147.102.97.104" | | SrcFileTime : "Thu Nov 29 09:48:44 2007" | | Generated by CCDGEN_2.5.5A on Fri Oct 14 21:41:52 2016 | | !!DO NOT MODIFY!!DO NOT MODIFY!!DO NOT MODIFY!! | +--------------------------------------------------------------------------+ */ /* PRAGMAS * PREFIX : NONE * COMPATIBILITY_DEFINES : NO (require PREFIX) * ALWAYS_ENUM_IN_VAL_FILE: NO * ENABLE_GROUP: NO * CAPITALIZE_TYPENAME: NO */ #ifndef P_MNSS_VAL #define P_MNSS_VAL #define CDG_ENTER__P_MNSS_VAL #define CDG_ENTER__FILENAME _P_MNSS_VAL #define CDG_ENTER__P_MNSS_VAL__FILE_TYPE CDGINC #define CDG_ENTER__P_MNSS_VAL__LAST_MODIFIED _2002_08_01 #define CDG_ENTER__P_MNSS_VAL__ID_AND_VERSION _6147_102_97_104 #define CDG_ENTER__P_MNSS_VAL__SRC_FILE_TIME _Thu_Nov_29_09_48_44_2007 #include "CDG_ENTER.h" #undef CDG_ENTER__P_MNSS_VAL #undef CDG_ENTER__FILENAME /* * Value constants for VAL_ti */ #define TI_RES_MO (0x7) /* reserved */ #define TI_RES_MT (0xf) /* reserved */ /* * Value constants for VAL_cause */ #define MNSS_CAUSE_UNASSIGN (0x600) /* Unassigned (unallocated) Note 9 number */ #define MNSS_CAUSE_NO_ROUTE (0x603) /* No route to destination */ #define MNSS_CAUSE_CHAN_UNACCEPT (0x606) /* Channel unacceptable */ #define MNSS_CAUSE_BARRED (0x608) /* Operator determined barring */ #define MNSS_CAUSE_CALL_CLEAR (0x610) /* Normal call clearing */ #define MNSS_CAUSE_USER_BUSY (0x611) /* User busy */ #define MNSS_CAUSE_NO_RESPONSE (0x612) /* No user responding */ #define MNSS_CAUSE_ALERT_NO_ANSWER (0x613) /* User alerting, no answer */ #define MNSS_CAUSE_CALL_REJECT (0x615) /* Call rejected */ #define MNSS_CAUSE_NUM_CHANGED (0x616) /* Number changed */ #define MNSS_CAUSE_PREEMPTION (0x619) /* Pre-emption */ #define MNSS_CAUSE_USER_CLEAR (0x61a) /* Non selected user clearing */ #define MNSS_CAUSE_DEST_ORDER (0x61b) /* Destination out of order */ #define MNSS_CAUSE_NUM_FORMAT (0x61c) /* Invalid number format (incomplete number) */ #define MNSS_CAUSE_FACILITY_REJECT (0x61d) /* Facility rejected */ #define MNSS_CAUSE_STATUS_ENQUIRY (0x61e) /* Response to STATUS ENQUIRY */ #define MNSS_CAUSE_UNSPECIFIED (0x61f) /* Normal, unspecified */ #define MNSS_CAUSE_NO_CHAN_AVAIL (0x622) /* No circuit/channel available */ #define MNSS_CAUSE_NETWORK_ORDER (0x626) /* Network out of order */ #define MNSS_CAUSE_TEMP_FAIL (0x629) /* Temporary failure */ #define MNSS_CAUSE_SWITCH_CONGEST (0x62a) /* Switching equipment congestion */ #define MNSS_CAUSE_INFO_DISCARD (0x62b) /* Access information discarded */ #define MNSS_CAUSE_REQ_CHAN_UNAVAIL (0x62c) /* requested circuit/channel not available */ #define MNSS_CAUSE_RESOURCE_UNAVAIL (0x62f) /* Resources unavailable, unspecified */ #define MNSS_CAUSE_QOS_UNAVAIL (0x631) /* Quality of service unavailable */ #define MNSS_CAUSE_FACILITY_UNSUBSCRIB (0x632) /* Requested facility not subscribed */ #define MNSS_CAUSE_BARRED_IN_CUG (0x637) /* Incoming calls barred within the CUG */ #define MNSS_CAUSE_BEARER_CAP_AUTHORIZ (0x639) /* Bearer capability not authorized */ #define MNSS_CAUSE_BEARER_CAP_UNAVAIL (0x63a) /* Bearer capability not presently available */ #define MNSS_CAUSE_SERVICE_UNAVAIL (0x63f) /* Service or option not available, unspecified */ #define MNSS_CAUSE_BEARER_NOT_IMPLEM (0x641) /* Bearer service not implemented */ #define MNSS_CAUSE_ACM_MAX (0x644) /* ACM equal to or greater than ACMmax */ #define MNSS_CAUSE_FACILITY_NOT_IMPLEM (0x645) /* Requested facility not implemented */ #define MNSS_CAUSE_RESTICT_BEARER_CAP (0x646) /* Only restricted digital information bearer capability is available */ #define MNSS_CAUSE_SERVICE_NOT_IMPLEM (0x64f) /* Service or option not implemented, unspecified */ #define MNSS_CAUSE_INVALID_TI (0x651) /* Invalid transaction identifier value */ #define MNSS_CAUSE_USER_NOT_IN_CUG (0x657) /* User not member of CUG */ #define MNSS_CAUSE_INCOMPAT_DEST (0x658) /* Incompatible destination */ #define MNSS_CAUSE_INVALID_TRANS_NET (0x65b) /* Invalid transit network selection */ #define MNSS_CAUSE_INCORRECT_MESSAGE (0x65f) /* Semantically incorrect message */ #define MNSS_CAUSE_INVALID_MAND_INFO (0x660) /* Invalid mandatory information */ #define MNSS_CAUSE_MESSAGE_TYPE_NOT_IMPLEM (0x661)/* Message type non-existent or not implemented */ #define MNSS_CAUSE_MESSAGE_TYPE_INCOMPAT (0x662) /* Message type not compatible with protocol state */ #define MNSS_CAUSE_INFO_ELEM_NOT_IMPLEM (0x663) /* Information element non existent or not implemented */ #define MNSS_CAUSE_COND_INFO_ELEM (0x664) /* Conditional IE error */ #define MNSS_CAUSE_MESSAGE_INCOMPAT (0x665) /* Message not compatible with protocol state */ #define MNSS_CAUSE_TIMER (0x666) /* Recovery on timer expiry */ #define MNSS_CAUSE_PROTOCOL (0x66f) /* Protocol error, unspecified */ #define MNSS_CAUSE_INTERWORKING (0x67f) /* Interworking, unspecified */ #define MNSS_CAUSE_NO_NET_CAUSE (0x86ff) /* Network initiated without cause */ /* * user defined constants */ #define FACILITY_LEN (0xfb) #define VERSION_LEN (0x8) #define SS_ORIGINATING_ENTITY (0x6) #include "CDG_LEAVE.h" #endif