FreeCalypso > hg > fc-magnetite
view cdg-hybrid/cdginc/p_mon.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | e7a67accfad9 |
| children |
line wrap: on
line source
/* +--------------------------------------------------------------------------+ | PROJECT : PROTOCOL STACK | | FILE : p_mon.h | | SOURCE : "sap\mon.pdf" | | LastModified : "2003-02-04" | | IdAndVersion : "8304.129.96.103" | | SrcFileTime : "Thu Nov 29 09:49:00 2007" | | Generated by CCDGEN_2.5.5A on Fri Oct 14 21:41:52 2016 | | !!DO NOT MODIFY!!DO NOT MODIFY!!DO NOT MODIFY!! | +--------------------------------------------------------------------------+ */ /* PRAGMAS * PREFIX : NONE * COMPATIBILITY_DEFINES : NO (require PREFIX) * ALWAYS_ENUM_IN_VAL_FILE: NO * ENABLE_GROUP: NO * CAPITALIZE_TYPENAME: NO */ #ifndef P_MON_H #define P_MON_H #define CDG_ENTER__P_MON_H #define CDG_ENTER__FILENAME _P_MON_H #define CDG_ENTER__P_MON_H__FILE_TYPE CDGINC #define CDG_ENTER__P_MON_H__LAST_MODIFIED _2003_02_04 #define CDG_ENTER__P_MON_H__ID_AND_VERSION _8304_129_96_103 #define CDG_ENTER__P_MON_H__SRC_FILE_TIME _Thu_Nov_29_09_49_00_2007 #include "CDG_ENTER.h" #undef CDG_ENTER__P_MON_H #undef CDG_ENTER__FILENAME #include "p_mon.val" #ifndef __T_plmn__ #define __T_plmn__ /* * PLMN identification * CCDGEN:WriteStruct_Count==2017 */ typedef struct { U8 v_plmn; /*< 0: 1> valid flag */ U8 mcc[SIZE_MCC]; /*< 1: 3> mobile country code */ U8 mnc[SIZE_MNC]; /*< 4: 3> mobile network code */ U8 _align0; /*< 7: 1> alignment */ } T_plmn; #endif /* * End of substructure section, begin of primitive definition section */ #ifndef __T_MON_CHAN_IDLE_IND__ #define __T_MON_CHAN_IDLE_IND__ /* * * CCDGEN:WriteStruct_Count==2018 */ typedef struct { U16 arfcn; /*< 0: 2> channel number */ U8 att_flag; /*< 2: 1> attach flag */ U8 conf_ccch; /*< 3: 1> CCCH configuration */ U8 tn; /*< 4: 1> timeslot number */ U8 dlt; /*< 5: 1> downlink initial value */ U8 pg; /*< 6: 1> paging group */ U8 bs_ag_blocks_res; /*< 7: 1> Blocks reserved for AGCH */ U8 bs_pa_mfrms; /*< 8: 1> Multiframe Period */ U8 power; /*< 9: 1> Power Level */ U8 _align0; /*< 10: 1> alignment */ U8 _align1; /*< 11: 1> alignment */ T_plmn plmn; /*< 12: 8> PLMN identification */ U16 lac; /*< 20: 2> location area code */ U16 cell_id; /*< 22: 2> cell identity */ } T_MON_CHAN_IDLE_IND; #endif #ifndef __T_MON_MEAS_IDLE_IND__ #define __T_MON_MEAS_IDLE_IND__ /* * * CCDGEN:WriteStruct_Count==2019 */ typedef struct { U16 arfcn; /*< 0: 2> channel number */ U8 bsic; /*< 2: 1> base station identification code */ U8 rx_lev; /*< 3: 1> received field strength */ U8 c1; /*< 4: 1> path loss criterion C1 */ U8 _align0; /*< 5: 1> alignment */ U16 arfcn_nc[6]; /*< 6: 12> channel number */ U8 bsic_nc[6]; /*< 18: 6> base station identification code */ U8 rx_lev_nc[6]; /*< 24: 6> received field strength */ U8 tav_nc[6]; /*< 30: 6> timing advance */ U8 c2_nc[6]; /*< 36: 6> reselection criterion C2 */ U8 _align1; /*< 42: 1> alignment */ U8 _align2; /*< 43: 1> alignment */ } T_MON_MEAS_IDLE_IND; #endif #ifndef __T_MON_COUNTER_IDLE_IND__ #define __T_MON_COUNTER_IDLE_IND__ /* * * CCDGEN:WriteStruct_Count==2020 */ typedef struct { U8 max_dlt; /*< 0: 1> maximum downlink timeout counter */ U8 act_dlt; /*< 1: 1> actual downlink timeout counter */ U8 _align0; /*< 2: 1> alignment */ U8 _align1; /*< 3: 1> alignment */ } T_MON_COUNTER_IDLE_IND; #endif #ifndef __T_MON_CHAN_DEDI_IND__ #define __T_MON_CHAN_DEDI_IND__ /* * * CCDGEN:WriteStruct_Count==2021 */ typedef struct { U8 ch_type; /*< 0: 1> channel type */ U8 _align0; /*< 1: 1> alignment */ U16 arfcn; /*< 2: 2> channel number */ U8 tsc; /*< 4: 1> training sequence code */ U8 tn; /*< 5: 1> timeslot number */ U8 ch_mode; /*< 6: 1> channel mode */ U8 hop; /*< 7: 1> frequency hopping flag */ U8 hsn; /*< 8: 1> hopping sequence number */ U8 maio; /*< 9: 1> mobile allocation offset */ U8 power; /*< 10: 1> Power Level */ U8 _align1; /*< 11: 1> alignment */ } T_MON_CHAN_DEDI_IND; #endif #ifndef __T_MON_MEAS_DEDI_IND__ #define __T_MON_MEAS_DEDI_IND__ /* * * CCDGEN:WriteStruct_Count==2022 */ typedef struct { U8 rx_lev_full; /*< 0: 1> received field strength */ U8 rx_lev_sub; /*< 1: 1> received field strength */ U8 rx_qual_full; /*< 2: 1> received quality */ U8 rx_qual_sub; /*< 3: 1> received quality */ U8 tav; /*< 4: 1> timing advance */ U8 _align0; /*< 5: 1> alignment */ U16 arfcn_nc[6]; /*< 6: 12> channel number */ U8 bsic_nc[6]; /*< 18: 6> base station identification code */ U8 rx_lev_nc[6]; /*< 24: 6> received field strength */ U8 tav_nc[6]; /*< 30: 6> timing advance */ } T_MON_MEAS_DEDI_IND; #endif #ifndef __T_MON_COUNTER_DEDI_IND__ #define __T_MON_COUNTER_DEDI_IND__ /* * * CCDGEN:WriteStruct_Count==2023 */ typedef struct { U8 max_rlt; /*< 0: 1> maximum radiolink timeout counter */ U8 act_rlt; /*< 1: 1> actual radiolink timeout counter */ U8 _align0; /*< 2: 1> alignment */ U8 _align1; /*< 3: 1> alignment */ } T_MON_COUNTER_DEDI_IND; #endif #ifndef __T_MON_COVERAGE_IND__ #define __T_MON_COVERAGE_IND__ /* * * CCDGEN:WriteStruct_Count==2024 */ typedef struct { U8 rx_lev[124]; /*< 0:124> received field strength */ U8 bsic[124]; /*<124:124> base station identification code */ } T_MON_COVERAGE_IND; #endif #include "CDG_LEAVE.h" #endif