FreeCalypso > hg > fc-magnetite

view cdg-hybrid/cdginc/p_rlp.val @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents e7a67accfad9
children
line wrap: on
line source

/*
+--------------------------------------------------------------------------+
| PROJECT : PROTOCOL STACK                                                 |
| FILE    : p_rlp.val                                                      |
| SOURCE  : "sap\rlp.pdf"                                                  |
| LastModified : "2002-04-22"                                              |
| IdAndVersion : "8411.101.98.115"                                         |
| SrcFileTime  : "Thu Nov 29 09:51:48 2007"                                |
| Generated by CCDGEN_2.5.5A on Fri Oct 14 21:41:52 2016                   |
|           !!DO NOT MODIFY!!DO NOT MODIFY!!DO NOT MODIFY!!                |
+--------------------------------------------------------------------------+
*/

/* PRAGMAS
 * PREFIX                 : NONE
 * COMPATIBILITY_DEFINES  : NO (require PREFIX)
 * ALWAYS_ENUM_IN_VAL_FILE: NO
 * ENABLE_GROUP: NO
 * CAPITALIZE_TYPENAME: NO
 */


#ifndef P_RLP_VAL
#define P_RLP_VAL


#define CDG_ENTER__P_RLP_VAL

#define CDG_ENTER__FILENAME _P_RLP_VAL
#define CDG_ENTER__P_RLP_VAL__FILE_TYPE CDGINC
#define CDG_ENTER__P_RLP_VAL__LAST_MODIFIED _2002_04_22
#define CDG_ENTER__P_RLP_VAL__ID_AND_VERSION _8411_101_98_115

#define CDG_ENTER__P_RLP_VAL__SRC_FILE_TIME _Thu_Nov_29_09_51_48_2007

#include "CDG_ENTER.h"

#undef CDG_ENTER__P_RLP_VAL

#undef CDG_ENTER__FILENAME


/*
 * Value constants for VAL_pt
 */
#define RLP_COMPR_TYPE_V42BIS          (0x0)      /* V.42bis                        */

/*
 * Value constants for VAL_p0
 */
#define RLP_COMP_DIR_NONE              (0x0)      /* compress in neither direction  */
#define RLP_COMP_DIR_TRANSMIT          (0x1)      /* compress in uplink direction only */
#define RLP_COMP_DIR_RECEIVE           (0x2)      /* compress in downlink direction only */
#define RLP_COMP_DIR_BOTH              (0x3)      /* compress in both directions    */

/*
 * Value constants for VAL_rate
 */
#define RLP_HALFRATE_4800              (0x0)      /* halfrate 4,8/6 kBit            */
#define RLP_FULLRATE_4800              (0x1)      /* fullrate 4,8/6 kBit            */
#define RLP_FULLRATE_9600              (0x2)      /* fullrate 9,6/12 kBit           */
#define RLP_FULLRATE_14400             (0x3)      /* fullrate 13,4/14,4 kBit        */

/*
 * Value constants for VAL_ack_flg
 */
#define RLP_ACK                        (0x0)      /* acknowledged                   */
#define RLP_NAK                        (0x1)      /* not acknowledged               */

/*
 * Value constants for VAL_cause
 */
#define RLP_ERR_PF_RETRANS             (0xc200)   /* Max Retransmissions of Poll reached */
#define RLP_ERR_XID_RETRANS            (0xc201)   /* Max Retransmissions of XID reached */
#define RLP_ERR_SABM_RETRANS           (0xc202)   /* Max Retransmissions of SABM reached */
#define RLP_ERR_DISC_RETRANS           (0xc203)   /* Max Retransmissions of DISC reached */
#define RLP_ERR_REMAP_RETRANS          (0xc204)   /* Max Retransmissions of REMAP reached */
#define RLP_ERR_SDU_TO_SMALL           (0xc210)   /* Received SDU is to small       */
#define RLP_ERR_INTERNAL               (0xc220)   /* Internal error                 */

/*
 * user defined constants
 */
#define RLP_HEADER_LEN                 (0x10)     
#define RLP_TRAILER_LEN                (0x0)      

#include "CDG_LEAVE.h"


#endif