src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.

/*
 * This version of fflags.h (ccdgen config file) is a FreeCalypso concoction.
 * Here I set all feature flags to OFF in order to create a configuration
 * that mimics the TCS211 program.
 */

#undef  FF_PS_RSSI
#undef  SIM_PERS
#undef  FF_PHONE_LOCK
#undef  TI_PS_FF_AT_CMD_P_ECC
#undef  TI_PS_FF_REL99_AND_ABOVE
#undef  TI_DUAL_MODE
#undef  REL99
#undef  FF_BHO
#undef  TI_PS_FF_EMR
#undef  TI_PS_FF_RTD
#undef  FF_EGPRS
#undef  REL4
#undef  TI_PS_FF_TBF_EST_PACCH
#undef  TI_PS_FF_QUAD_BAND_SUPPORT