FreeCalypso > hg > fc-magnetite

view cdg-hybrid/sap-inline/cl_inline.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents e7a67accfad9
children
line wrap: on
line source

/***
;********************************************************************************
;*** File           : cl_inline.h
;*** Creation       : Wed Mar 11 09:58:09 CST 2009
;*** XSLT Processor : Apache Software Foundation / http://xml.apache.org/xalan-j / supports XSLT-Ver: 1
;*** Copyright      : (c) Texas Instruments AG, Berlin Germany 2002
;********************************************************************************
;*** Document Type  : Service Access Point Specification
;*** Document Name  : cl
;*** Document No.   : 8010.149.04.012
;*** Document Date  : 2004-06-08
;*** Document Status: SUBMITTED
;*** Document Author: rpk
;********************************************************************************
;*** !!! THIS INCLUDE FILE WAS GENERATED AUTOMATICALLY, DO NOT MODIFY !!!
;********************************************************************************
 ***/
#ifndef _CL_INLINE_H_
#define _CL_INLINE_H_



extern  void cl_nwrl_set_sgsn_release ( U8 sgsn_rel );

extern  U8 cl_nwrl_get_sgsn_release ( void );

extern  U8 cl_qos_convert_r99_to_r97 ( T_PS_qos_r99 *src_qos_r99, T_PS_qos_r97 *dst_qos_r97 );

extern  U8 cl_qos_convert_r97_to_r99 ( T_PS_qos_r97 *src_qos_r97, T_PS_qos_r99 *dst_qos_r99 );




#endif /* !_CL_INLINE_H_ */