FreeCalypso > hg > fc-magnetite

view cdg-hybrid/sap/ph.pdf @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents e7a67accfad9
children
line wrap: on
line source

;********************************************************************************
;*** File           : ph.pdf
;*** Creation       : Wed Mar 11 09:58:34 CST 2009
;*** XSLT Processor : Apache Software Foundation / http://xml.apache.org/xalan-j / supports XSLT-Ver: 1
;*** Copyright      : (c) Texas Instruments AG, Berlin Germany 2002
;********************************************************************************
;*** Document Type  : Service Access Point Specification
;*** Document Name  : ph
;*** Document No.   : 6147.112.01.100
;*** Document Date  : 2001-10-26
;*** Document Status: APPROVED
;*** Document Author: SBK
;********************************************************************************



PRAGMA 	SRC_FILE_TIME 	"Thu Nov 29 09:50:28 2007"
PRAGMA 	LAST_MODIFIED 	"2001-10-26"
PRAGMA 	ID_AND_VERSION 	"6147.112.01.100"



CONST 	DUMMY_PH 	0 	; Dummy, not used, needed to satisfy tool chain which requires at least one constant definition in a SAP



VALTAB 	VAL_ch_type
VAL 	0 	CH_TYPE_SACCH 	"SACCH"
VAL 	1 	CH_TYPE_SDCCH 	"SDCCH"
VAL 	2 	CH_TYPE_FACCH 	"FACCH Full Rate"
VAL 	3 	 	"reserved"
VAL 	4 	 	"reserved"
VAL 	5 	 	"reserved"
VAL 	6 	 	"reserved"
VAL 	7 	CH_TYPE_FACCH_HR 	"FACCH Half Rate"




VAR 	l2_channel 	"Layer 2 channel-type" 	B

VAL 	@p_mphc - VAL_l2_channel@ 	

VAR 	l_buf 	"length of content in bit" 	S


VAR 	o_buf 	"offset of content in bit" 	S


VAR 	buf 	"buffer content; the actual size of buf is determined and allocated at run-time and not restricted to 1;" 	B


VAR 	dummy 	"dummy not used" 	B





COMP 	sdu 	 "message unit"
{
 	l_buf 	 ; length of content in bit
 	o_buf 	 ; offset of content in bit
 	buf 	[1] 	 ; buffer content; the actual size of buf is determined and allocated at run-time and not restricted to 1;
}






; PH_READY_TO_SEND 	0x4100
; PH_DATA_REQ 	0x0100
; PH_TRACE_IND 	0x4102



PRIM 	PH_READY_TO_SEND 	0x4100
{
 	l2_channel AS ch_type 	 ; channel type
}






PRIM 	PH_DATA_REQ 	0x0100
{
 	l2_channel AS ch_type 	 ; channel type
 	dummy 	 ; dummy not used; reserved
 	sdu 	 ; message unit
}






PRIM 	PH_TRACE_IND 	0x4102
{
 	dummy 	 ; dummy not used; not used
}