FreeCalypso > hg > fc-magnetite
view cdg-hybrid/sap/tb.pdf @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 22 Jul 2018 06:04:49 +0000 |
parents | e7a67accfad9 |
children |
line wrap: on
line source
;******************************************************************************** ;*** File : tb.pdf ;*** Creation : Wed Mar 11 09:58:52 CST 2009 ;*** XSLT Processor : Apache Software Foundation / http://xml.apache.org/xalan-j / supports XSLT-Ver: 1 ;*** Copyright : (c) Texas Instruments AG, Berlin Germany 2002 ;******************************************************************************** ;*** Document Type : Service Access Point Specification ;*** Document Name : tb ;*** Document No. : 8441.112.01.002 ;*** Document Date : 2001-07-17 ;*** Document Status: BEING_PROCESSED ;*** Document Author: SAB ;******************************************************************************** PRAGMA SRC_FILE_TIME "Thu Nov 29 09:54:48 2007" PRAGMA LAST_MODIFIED "2001-07-17" PRAGMA ID_AND_VERSION "8441.112.01.002" CONST TB_BA_LIST_SIZE 33 ; BA list size VALTAB VAL_arfcn VAL 1 - 124 "GSM 900 without extension band" VAL 1 - 174 "GSM 900 with extension band" VAL 512 - 810 "PCS 1900" VAL 512 - 885 "DCS 1800" VAL 1 - 498 "Dual band(GSM/DCS)" VAL 1 - 548 "Dual band(EGSM/DCS)" VAL 0xFFFF TB_INVALID_ARFCN "Used to mark a channel number entry as invalid." VAR num_meas "number" B VAR rxlev "measurement value" S VAR arfcn "channel number" S VAL @p_tb - VAL_arfcn@ VAR sc_rxlev "RXLEV value of the serving cell." B COMP tb_meas_result "" { arfcn ; Channel Number rxlev ; ACC Level num_meas ; ACC nbr } ; TB_MEAS_IND 0x1800 ; TB_RXLEV_SC_REQ 0x5800 PRIM TB_MEAS_IND 0x1800 { tb_meas_result [TB_BA_LIST_SIZE] ; Measurement result } PRIM TB_RXLEV_SC_REQ 0x5800 { sc_rxlev ; RXLEV Serving Cell }