FreeCalypso > hg > fc-magnetite

view cdg211/cdginc/p_aci.val @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 56abf6cf8a0b
children
line wrap: on
line source

/*
+--------------------------------------------------------------------------+
| PROJECT : PROTOCOL STACK                                                 |
| FILE    : p_aci.val                                                      |
| SOURCE  : "__out__\g23m_dfile\prim\aci.pdf"                              |
| LastModified : "2004-06-01"                                              |
| IdAndVersion : "8411.105.00.205"                                         |
| SrcFileTime  : "Mon Jun 7 15:08:48 2004"                                 |
| Generated by CCDGEN_2.5.5 on Fri Jun 08 13:59:14 2007                    |
|           !!DO NOT MODIFY!!DO NOT MODIFY!!DO NOT MODIFY!!                |
+--------------------------------------------------------------------------+
*/

/* PRAGMAS
 * PREFIX                 : NONE
 * COMPATIBILITY_DEFINES  : NO (require PREFIX)
 * ALWAYS_ENUM_IN_VAL_FILE: NO
 * ENABLE_GROUP: NO
 * CAPITALIZE_TYPENAME: NO
 */


#ifndef P_ACI_VAL
#define P_ACI_VAL


#define CDG_ENTER__P_ACI_VAL

#define CDG_ENTER__FILENAME _P_ACI_VAL
#define CDG_ENTER__P_ACI_VAL__FILE_TYPE CDGINC
#define CDG_ENTER__P_ACI_VAL__LAST_MODIFIED _2004_06_01
#define CDG_ENTER__P_ACI_VAL__ID_AND_VERSION _8411_105_00_205

#define CDG_ENTER__P_ACI_VAL__SRC_FILE_TIME _Mon_Jun_7_15_08_48_2004

#include "CDG_ENTER.h"

#undef CDG_ENTER__P_ACI_VAL

#undef CDG_ENTER__FILENAME


/*
 * Value constants for VAL_cmd_src
 */
#define CMD_SRC_INT                    (0x0)      /* Command from internal application */
#define CMD_SRC_EXT                    (0x1)      /* Command from external application */
#define CMD_SRC_UNKNOWN                (0xff)     /* Reserved                       */

/*
 * Value constants for VAL_urt_stat
 */
#define URT_RDY_TO_SEND                (0x0)      /* URT is ready to accept new data */
#define URT_DATA_AVAIL                 (0x1)      /* URT has data available         */
#define URT_STAT_UNKNOWN               (0xff)     /* Reserved                       */

/*
 * Value constants for VAL_cause
 */
#define ABT_ABORT_DATA                 (0x0)      /* Abort data mode                */
#define ABT_ABORT_CMD                  (0x1)      /* Abort current command          */

/*
 * Value constants for VAL_ackflg
 */
#define ACI_NAK                        (0x0)      /* Not Acknowledge                */
#define ACI_ACK                        (0x1)      /* Acknowledge                    */

/*
 * user defined constants
 */
#define MAX_CMD_LEN                    (0x17c)    
#define MAX_TRC_LEN                    (0x50)     
#define MAX_DATA_LEN                   (0xc8)     

#include "CDG_LEAVE.h"


#endif