FreeCalypso > hg > fc-magnetite

view cdg211/cdginc/p_mnlc.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 56abf6cf8a0b
children
line wrap: on
line source

/*
+--------------------------------------------------------------------------+
| PROJECT : PROTOCOL STACK                                                 |
| FILE    : p_mnlc.h                                                       |
| SOURCE  : "__out__\g23m_dfile\prim\mnlc.pdf"                             |
| LastModified : "2002-10-25"                                              |
| IdAndVersion : "8443.104.02.003"                                         |
| SrcFileTime  : "Mon Nov 24 15:50:46 2003"                                |
| Generated by CCDGEN_2.5.5 on Fri Jun 08 13:59:15 2007                    |
|           !!DO NOT MODIFY!!DO NOT MODIFY!!DO NOT MODIFY!!                |
+--------------------------------------------------------------------------+
*/

/* PRAGMAS
 * PREFIX                 : NONE
 * COMPATIBILITY_DEFINES  : NO (require PREFIX)
 * ALWAYS_ENUM_IN_VAL_FILE: NO
 * ENABLE_GROUP: NO
 * CAPITALIZE_TYPENAME: NO
 */


#ifndef P_MNLC_H
#define P_MNLC_H


#define CDG_ENTER__P_MNLC_H

#define CDG_ENTER__FILENAME _P_MNLC_H
#define CDG_ENTER__P_MNLC_H__FILE_TYPE CDGINC
#define CDG_ENTER__P_MNLC_H__LAST_MODIFIED _2002_10_25
#define CDG_ENTER__P_MNLC_H__ID_AND_VERSION _8443_104_02_003

#define CDG_ENTER__P_MNLC_H__SRC_FILE_TIME _Mon_Nov_24_15_50_46_2003

#include "CDG_ENTER.h"

#undef CDG_ENTER__P_MNLC_H

#undef CDG_ENTER__FILENAME


#include "p_mnlc.val"

#ifndef __T_called_party_bcd_num__
#define __T_called_party_bcd_num__
/*
 * called Party Bcd number
 * CCDGEN:WriteStruct_Count==1539
 */
typedef struct
{
  U8                        number_length;            /*<  0:  1> Number of decimal digits in the Bcd number         */
  U8                        bcd[L_MAX_CALLED_BCD_NO_LENGTH]; /*<  1: 10> Bcd Number                                         */
  U8                        _align0;                  /*< 11:  1> alignment                                          */
} T_called_party_bcd_num;
#endif


/*
 * End of substructure section, begin of primitive definition section
 */

#ifndef __T_MNLC_SMS_MEAS_REQ__
#define __T_MNLC_SMS_MEAS_REQ__
/*
 * 
 * CCDGEN:WriteStruct_Count==1540
 */
typedef struct
{
  U16                       reference;                /*<  0:  2> Reference                                          */
  U8                        _align0;                  /*<  2:  1> alignment                                          */
  U8                        _align1;                  /*<  3:  1> alignment                                          */
  T_called_party_bcd_num    called_party_bcd_num;     /*<  4: 12> called Party Bcd number                            */
} T_MNLC_SMS_MEAS_REQ;
#endif

#ifndef __T_MNLC_SMS_MEAS_CNF__
#define __T_MNLC_SMS_MEAS_CNF__
/*
 * 
 * CCDGEN:WriteStruct_Count==1541
 */
typedef struct
{
  U16                       reference;                /*<  0:  2> Reference                                          */
  U8                        data_valid;               /*<  2:  1> Cursor Data Valid                                  */
  U8                        sms_text[CURSOR_SMS_TEXT_140]; /*<  3:140> SMS text                                           */
  U8                        _align0;                  /*<143:  1> alignment                                          */
} T_MNLC_SMS_MEAS_CNF;
#endif


#include "CDG_LEAVE.h"


#endif