FreeCalypso > hg > fc-magnetite
view cdg211/cdginc/p_ra.val @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | 56abf6cf8a0b |
| children |
line wrap: on
line source
/* +--------------------------------------------------------------------------+ | PROJECT : PROTOCOL STACK | | FILE : p_ra.val | | SOURCE : "__out__\g23m_dfile\prim\ra.pdf" | | LastModified : "2002-04-26" | | IdAndVersion : "8411.102.98.204" | | SrcFileTime : "Mon Nov 24 15:51:06 2003" | | Generated by CCDGEN_2.5.5 on Fri Jun 08 13:59:16 2007 | | !!DO NOT MODIFY!!DO NOT MODIFY!!DO NOT MODIFY!! | +--------------------------------------------------------------------------+ */ /* PRAGMAS * PREFIX : NONE * COMPATIBILITY_DEFINES : NO (require PREFIX) * ALWAYS_ENUM_IN_VAL_FILE: NO * ENABLE_GROUP: NO * CAPITALIZE_TYPENAME: NO */ #ifndef P_RA_VAL #define P_RA_VAL #define CDG_ENTER__P_RA_VAL #define CDG_ENTER__FILENAME _P_RA_VAL #define CDG_ENTER__P_RA_VAL__FILE_TYPE CDGINC #define CDG_ENTER__P_RA_VAL__LAST_MODIFIED _2002_04_26 #define CDG_ENTER__P_RA_VAL__ID_AND_VERSION _8411_102_98_204 #define CDG_ENTER__P_RA_VAL__SRC_FILE_TIME _Mon_Nov_24_15_51_06_2003 #include "CDG_ENTER.h" #undef CDG_ENTER__P_RA_VAL #undef CDG_ENTER__FILENAME /* * Value constants for VAL_model */ #define RA_MODEL_SPEECH (0x0) /* model speech */ #define RA_MODEL_TRANS (0x1) /* model 1b async transparent */ #define RA_MODEL_RLP (0x2) /* model 3b async nontransparent */ #define RA_MODEL_FAX (0x3) /* model 5b fax 3.45 */ /* * Value constants for VAL_tra_rate */ #define TRA_FULLRATE_2400 (0x0) /* fullrate 2,4/3,6 kBit */ #define TRA_HALFRATE_2400 (0x1) /* halfrate 2,4/3,6 kBit */ #define TRA_FULLRATE_4800 (0x2) /* fullrate 4,8/6 kBit */ #define TRA_HALFRATE_4800 (0x3) /* halfrate 4,8/6 kBit */ #define TRA_FULLRATE_9600 (0x4) /* fullrate 9,6/12 kBit */ #define TRA_FULLRATE_14400 (0x5) /* fullrate 13,4/14,4 kBit */ /* * Value constants for VAL_user_rate */ #define URA_300 (0x0) /* user rate 300bps */ #define URA_1200 (0x1) /* user rate 1200bps */ #define URA_2400 (0x2) /* user rate 2400bps */ #define URA_4800 (0x3) /* user rate 4800bps */ #define URA_9600 (0x4) /* user rate 9600bps */ #define URA_1200_75 (0x5) /* user rate 1200/75bps */ #define URA_14400 (0x6) /* user rate 14400bps */ /* * Value constants for VAL_dtx_flg */ #define DTX_DIS (0x0) /* Disable DTX */ #define DTX_EN (0x1) /* Enable DTX */ /* * Value constants for VAL_fr_type */ #define FR_T4DATA (0x0) /* GSM 3.45 Data frame */ #define FR_STATUS (0x1) /* GSM 3.45 Status (BCS) frame */ #define FR_SYNC (0x2) /* GSM 3.45 Sync frame */ #define FR_TRAIN (0x3) /* GSM 3.45 Status (TRAIN) frame */ #define FR_TRANS (0x4) /* Transparent Data frame */ #define FR_RLP (0x5) /* Valid RLP frame */ #define FR_INVALID (0xf) /* Invalid frame or FCS error detected in RLP mode */ /* * Value constants for VAL_status */ #define ST_SA (0x1) /* Status SA */ #define ST_SB (0x2) /* Status SB */ #define ST_X (0x4) /* Status X */ #define ST_OVER (0x8) /* Overspeed flag */ /* * Value constants for VAL_ack_flg */ #define RA_ACK (0x0) /* acknowledged */ #define RA_NAK (0x1) /* not acknowledged */ /* * Value constants for VAL_detect */ #define DET_NO_STATUS (0x0) /* do not detect status frames */ #define DET_STATUS (0x1) /* detect status frames */ /* * Value constants for VAL_tick_dir */ #define TICK_UL (0x1) /* tick uplink */ #define TICK_DL (0x2) /* tick downlink */ #define TICK_UL_DL (0x3) /* tick uplink & downlink */ /* * Value constants for VAL_offset */ #define ra_conf (0x0) /* Configurations */ #define ra_act (0x1) /* Activities */ #define ra_test (0x2) /* Test */ #define ra_statu (0x3) /* Uplink status */ #define ra_statd (0x4) /* Downlink status */ #define fax_status_det (0x5) /* Fax status detection */ #define rau (0x6) /* Buffer for uplink characters */ #define rad (0x7) /* Buffer for downlink characters */ #define ntu (0x8) /* Buffer for uplink RLP frames */ #define ntd (0x9) /* Buffer for downlink RLP frames */ #define faxu (0xa) /* Buffer for uplink fax data */ #define faxd (0xb) /* Buffer for downlink fax data */ /* * user defined constants */ #define DUMMY_RA (0x0) #include "CDG_LEAVE.h" #endif