FreeCalypso > hg > fc-magnetite
view cdg211/cdginc/p_rrlp.val @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 22 Jul 2018 06:04:49 +0000 |
parents | 56abf6cf8a0b |
children |
line wrap: on
line source
/* +--------------------------------------------------------------------------+ | PROJECT : PROTOCOL STACK | | FILE : p_rrlp.val | | SOURCE : "__out__\g23m_dfile\prim\rrlp.pdf" | | LastModified : "2002-11-13" | | IdAndVersion : "8443.102.02.100" | | SrcFileTime : "Mon Nov 24 15:49:24 2003" | | Generated by CCDGEN_2.5.5 on Fri Jun 08 13:59:16 2007 | | !!DO NOT MODIFY!!DO NOT MODIFY!!DO NOT MODIFY!! | +--------------------------------------------------------------------------+ */ /* PRAGMAS * PREFIX : NONE * COMPATIBILITY_DEFINES : NO (require PREFIX) * ALWAYS_ENUM_IN_VAL_FILE: NO * ENABLE_GROUP: NO * CAPITALIZE_TYPENAME: NO */ #ifndef P_RRLP_VAL #define P_RRLP_VAL #define CDG_ENTER__P_RRLP_VAL #define CDG_ENTER__FILENAME _P_RRLP_VAL #define CDG_ENTER__P_RRLP_VAL__FILE_TYPE CDGINC #define CDG_ENTER__P_RRLP_VAL__LAST_MODIFIED _2002_11_13 #define CDG_ENTER__P_RRLP_VAL__ID_AND_VERSION _8443_102_02_100 #define CDG_ENTER__P_RRLP_VAL__SRC_FILE_TIME _Mon_Nov_24_15_49_24_2003 #include "CDG_ENTER.h" #undef CDG_ENTER__P_RRLP_VAL #undef CDG_ENTER__FILENAME /* * Value constants for VAL_cause */ #define RRLP_METHOD_INVALID (0x7) /* Position method is not supported */ #define RRLP_REF_BTS_INVALID (0xa) /* The ref. BTS for E-OTD is not the serving BTS */ #define RRLP_HANDOVER (0x14) /* The measurement procedure was interrupted by a handover. No RRLP specific error message is created. */ /* * Value constants for VAL_exp_otd */ /* * Value constants for VAL_loc_method */ #define EOTD_METHOD (0x0) #define GPS_METOD (0x1) #define GPS_OR_EOTD_METOD (0x2) /* * Value constants for VAL_mfrm_offset */ /* * Value constants for VAL_otd_type */ #define ROUGH_RTD (0x0) /* only rough RTD has been provided by the NW */ #define EXPECTED_OTD (0x1) /* only expectedOTD has been provided by the NW */ #define BOTH_OTD (0x2) /* Both OTD / RTD types have been provided by the NW */ /* * Value constants for VAL_pos_method */ #define MS_ASSISTED (0x0) #define MS_BASED (0x1) #define MS_BASED_PREF (0x2) #define MS_ASSISTED_PREF (0x3) /* * Value constants for VAL_rough_rtd */ /* * Value constants for VAL_ta_correction_present */ #define TA_PRESENT (0x1) /* TA present */ #define TA_NOT_PRESENT (0x0) /* TA NOT present */ /* * Value constants for VAL_uncertainty */ #define UNC_MAX_2BIT (0x0) /* uncertainty in bits. 0 - 2 bits */ #define UNC_MAX_4BIT (0x1) /* uncertainty in bits. 3 - 4 bits */ #define UNC_MAX_8BIT (0x2) /* uncertainty in bits. 5 - 8 bits */ #define UNC_MAX_12BIT (0x3) /* uncertainty in bits. 9 - 12 bits */ #define UNC_MAX_16BIT (0x4) /* uncertainty in bits. 13 - 16 bits */ #define UNC_MAX_22BIT (0x5) /* uncertainty in bits. 17 - 22 bits */ #define UNC_MAX_30BIT (0x6) /* uncertainty in bits. 23 - 30 bits */ #define UNC_GT_30BIT (0x7) /* uncertainty in bits. > 30 bits */ /* * user defined constants */ #define R_NUM_MEAS_SETS (0x3) #define R_MAX_REF_NEIGH_BTS (0xf) #define MAX_NCELL_EOTD (0xf) #include "CDG_LEAVE.h" #endif