FreeCalypso > hg > fc-magnetite
view cdg211/cdginc/p_tra.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | 56abf6cf8a0b |
| children |
line wrap: on
line source
/* +--------------------------------------------------------------------------+ | PROJECT : PROTOCOL STACK | | FILE : p_tra.h | | SOURCE : "__out__\g23m_dfile\prim\tra.pdf" | | LastModified : "2002-06-10" | | IdAndVersion : "8411.106.98.101" | | SrcFileTime : "Mon Nov 24 15:49:20 2003" | | Generated by CCDGEN_2.5.5 on Fri Jun 08 13:59:16 2007 | | !!DO NOT MODIFY!!DO NOT MODIFY!!DO NOT MODIFY!! | +--------------------------------------------------------------------------+ */ /* PRAGMAS * PREFIX : NONE * COMPATIBILITY_DEFINES : NO (require PREFIX) * ALWAYS_ENUM_IN_VAL_FILE: NO * ENABLE_GROUP: NO * CAPITALIZE_TYPENAME: NO */ #ifndef P_TRA_H #define P_TRA_H #define CDG_ENTER__P_TRA_H #define CDG_ENTER__FILENAME _P_TRA_H #define CDG_ENTER__P_TRA_H__FILE_TYPE CDGINC #define CDG_ENTER__P_TRA_H__LAST_MODIFIED _2002_06_10 #define CDG_ENTER__P_TRA_H__ID_AND_VERSION _8411_106_98_101 #define CDG_ENTER__P_TRA_H__SRC_FILE_TIME _Mon_Nov_24_15_49_20_2003 #include "CDG_ENTER.h" #undef CDG_ENTER__P_TRA_H #undef CDG_ENTER__FILENAME #include "p_tra.val" /* * End of substructure section, begin of primitive definition section */ #ifndef __T_TRA_ACTIVATE_REQ__ #define __T_TRA_ACTIVATE_REQ__ /* * * CCDGEN:WriteStruct_Count==2199 */ typedef struct { U8 dummy; /*< 0: 1> no parameters */ } T_TRA_ACTIVATE_REQ; #endif #ifndef __T_TRA_ACTIVATE_CNF__ #define __T_TRA_ACTIVATE_CNF__ /* * * CCDGEN:WriteStruct_Count==2200 */ typedef struct { U8 ack_flg; /*< 0: 1> acknowledge flag */ U8 _align0; /*< 1: 1> alignment */ U8 _align1; /*< 2: 1> alignment */ U8 _align2; /*< 3: 1> alignment */ } T_TRA_ACTIVATE_CNF; #endif #ifndef __T_TRA_DEACTIVATE_REQ__ #define __T_TRA_DEACTIVATE_REQ__ /* * * CCDGEN:WriteStruct_Count==2201 */ typedef struct { U8 dummy; /*< 0: 1> no parameters */ } T_TRA_DEACTIVATE_REQ; #endif #ifndef __T_TRA_DEACTIVATE_CNF__ #define __T_TRA_DEACTIVATE_CNF__ /* * * CCDGEN:WriteStruct_Count==2202 */ typedef struct { U8 dummy; /*< 0: 1> no parameters */ } T_TRA_DEACTIVATE_CNF; #endif #ifndef __T_TRA_DTI_REQ__ #define __T_TRA_DTI_REQ__ /* * * CCDGEN:WriteStruct_Count==2203 */ typedef struct { U8 dti_conn; /*< 0: 1> DTI connect */ U8 _align0; /*< 1: 1> alignment */ U8 _align1; /*< 2: 1> alignment */ U8 _align2; /*< 3: 1> alignment */ U32 link_id; /*< 4: 4> link identifier */ U8 entity_name[TRA_ENTITY_NAME_LEN]; /*< 8: 6> name of an neighbour entity */ U8 dti_direction; /*< 14: 1> DTI direction */ U8 _align3; /*< 15: 1> alignment */ } T_TRA_DTI_REQ; #endif #ifndef __T_TRA_DTI_CNF__ #define __T_TRA_DTI_CNF__ /* * * CCDGEN:WriteStruct_Count==2204 */ typedef struct { U8 dti_conn; /*< 0: 1> DTI connect */ U8 _align0; /*< 1: 1> alignment */ U8 _align1; /*< 2: 1> alignment */ U8 _align2; /*< 3: 1> alignment */ U32 link_id; /*< 4: 4> link identifier */ } T_TRA_DTI_CNF; #endif #ifndef __T_TRA_DTI_IND__ #define __T_TRA_DTI_IND__ /* * * CCDGEN:WriteStruct_Count==2205 */ typedef struct { U32 link_id; /*< 0: 4> link identifier */ } T_TRA_DTI_IND; #endif #include "CDG_LEAVE.h" #endif