FreeCalypso > hg > fc-magnetite

view cdg211/prim/rrrrlp.pdf @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 56abf6cf8a0b
children
line wrap: on
line source

;********************************************************************************
;*** File           : rrrrlp.pdf
;*** Creation       : Fri Jun 08 13:58:29 CST 2007
;*** XSLT Processor : Apache Software Foundation / http://xml.apache.org/xalan-j / supports XSLT-Ver: 1
;*** Copyright      : (c) Texas Instruments AG, Berlin Germany 2002
;********************************************************************************
;*** Document Type  : Service Access Point Specification
;*** Document Name  : rrrrlp
;*** Document No.   : 0000.000.00.002
;*** Document Date  : 2002-09-10
;*** Document Status: BEING_PROCESSED
;*** Document Author: VK
;********************************************************************************



PRAGMA 	SRC_FILE_TIME 	"Mon Nov 24 15:51:14 2003"
PRAGMA 	LAST_MODIFIED 	"2002-09-10"
PRAGMA 	ID_AND_VERSION 	"0000.000.00.002"



CONST 	MAX_SDU_LEN 	1 	; 
CONST 	MAX_NCELL_L1 	12 	; Max no. of NC layer 1 is able to measure
CONST 	MAX_NCELL_EOTD 	15 	; Max no. of NC reported in the Measurement Assistance Data Element (3GPP 04.31)
CONST 	MAX_NCELL_EOTD_SI 	32 	; Max no. of NC reported in the Measurement Assistance Data SI List Element (3GPP 04.31)






VAR 	dummy 	"Dummy" 	B


VAR 	l_buf 	"length in bits" 	S


VAR 	o_buf 	"offset in bits" 	S


VAR 	buf 	"bit buffer" 	B


VAR 	cr 	"Command or Response" 	B





COMP 	sdu 	 "Service Data Unit"
{
 	l_buf 	 ; length in bits
 	o_buf 	 ; offset in bits
 	buf 	[MAX_SDU_LEN] 	 ; bit buffer
}






; RRRRLP_DATA_IND 	0x80004041
; RRRRLP_DATA_REQ 	0x80000041
; RRRRLP_DATA_CNF 	0x80014041
; RRRRLP_ERROR_IND 	0x80024041



PRIM 	RRRRLP_DATA_IND 	0x80004041
{
 	cr 	 ; Command / Response
 	sdu 	 ; APDU_IND
}






PRIM 	RRRRLP_DATA_REQ 	0x80000041
{
 	cr 	 ; Command / Response
 	sdu 	 ; APDU_REQ
}






PRIM 	RRRRLP_DATA_CNF 	0x80014041
{
 	dummy 	 ; Dummy
}






PRIM 	RRRRLP_ERROR_IND 	0x80024041
{
 	dummy 	 ; Dummy
}