FreeCalypso > hg > fc-magnetite

view cdg3/cdginc-conservative/m_tst.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents c15047b3d00d
children
line wrap: on
line source

/*
+--------------------------------------------------------------------------+
| PROJECT : PROTOCOL STACK                                                 |
| FILE    : m_tst.h                                                        |
| SOURCE  : "msg\tst.mdf"                                                  |
| LastModified : "2000-10-23"                                              |
| IdAndVersion : "8441.603.99.005"                                         |
| SrcFileTime  : "Wed Nov 28 10:21:30 2007"                                |
| Generated by CCDGEN_2.5.5A on Thu Sep 25 09:52:55 2014                   |
|           !!DO NOT MODIFY!!DO NOT MODIFY!!DO NOT MODIFY!!                |
+--------------------------------------------------------------------------+
*/

/* PRAGMAS
 * PREFIX                 : NONE
 * COMPATIBILITY_DEFINES  : NO (require PREFIX)
 * ALWAYS_ENUM_IN_VAL_FILE: NO
 * ENABLE_GROUP: NO
 * CAPITALIZE_TYPENAME: NO
 */


#ifndef M_TST_H
#define M_TST_H


#define CDG_ENTER__M_TST_H

#define CDG_ENTER__FILENAME _M_TST_H
#define CDG_ENTER__M_TST_H__FILE_TYPE CDGINC
#define CDG_ENTER__M_TST_H__LAST_MODIFIED _2000_10_23
#define CDG_ENTER__M_TST_H__ID_AND_VERSION _8441_603_99_005

#define CDG_ENTER__M_TST_H__SRC_FILE_TIME _Wed_Nov_28_10_21_30_2007

#include "CDG_ENTER.h"

#undef CDG_ENTER__M_TST_H

#undef CDG_ENTER__FILENAME


#include "m_tst.val"

#ifndef __T_pdu_description__
#define __T_pdu_description__
/*
 * PDU Description
 * CCDGEN:WriteStruct_Count==772
 */
typedef struct
{
  U16                       no_of_pdus;               /*<  0:  2> Number of PDUs                                     */
  U8                        _align0;                  /*<  2:  1> alignment                                          */
  U8                        _align1;                  /*<  3:  1> alignment                                          */
} T_pdu_description;
#endif

#ifndef __T_pdu_description_ie__
#define __T_pdu_description_ie__
/*
 * PDU Description IE
 * CCDGEN:WriteStruct_Count==773
 */
typedef struct
{
  U8                        _align0;                  /*<  0:  1> alignment                                          */
  U8                        _align1;                  /*<  1:  1> alignment                                          */
  U8                        _align2;                  /*<  2:  1> alignment                                          */
  U8                        v_pdu_description;        /*<  3:  1> valid-flag                                         */
  T_pdu_description         pdu_description;          /*<  4:  4> PDU Description                                    */
} T_pdu_description_ie;
#endif

#ifndef __T_mode_flag__
#define __T_mode_flag__
/*
 * Mode Flag
 * CCDGEN:WriteStruct_Count==774
 */
typedef struct
{
  U8                        dl_timeslot_offset;       /*<  0:  1> Downlink Timeslot Offset                           */
  U8                        mode_flag_val;            /*<  1:  1> Mode Flag Value                                    */
  U8                        _align0;                  /*<  2:  1> alignment                                          */
  U8                        _align1;                  /*<  3:  1> alignment                                          */
} T_mode_flag;
#endif


/*
 * End of substructure section, begin of message definition section
 */

#ifndef __T_GPRS_TEST_MODE_CMD__
#define __T_GPRS_TEST_MODE_CMD__
/*
 * 
 * CCDGEN:WriteStruct_Count==775
 */
typedef struct
{
  U8                        msg_type;                 /*<  0:  1> Message Type                                       */
  U8                        _align0;                  /*<  1:  1> alignment                                          */
  U8                        _align1;                  /*<  2:  1> alignment                                          */
  U8                        _align2;                  /*<  3:  1> alignment                                          */
  T_pdu_description_ie      pdu_description_ie;       /*<  4:  8> PDU Description IE                                 */
  T_mode_flag               mode_flag;                /*< 12:  4> Mode Flag                                          */
} T_GPRS_TEST_MODE_CMD;
#endif


#include "CDG_LEAVE.h"


#endif