FreeCalypso > hg > fc-magnetite

view cdg3/cdginc-conservative/p_8010_135_sn_sap.val @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents c15047b3d00d
children
line wrap: on
line source

/*
+--------------------------------------------------------------------------+
| PROJECT : PROTOCOL STACK                                                 |
| FILE    : p_8010_135_sn_sap.val                                          |
| SOURCE  : "sap\8010_135_sn_sap.pdf"                                      |
| LastModified : "2004-06-08"                                              |
| IdAndVersion : "8010.135.04.012"                                         |
| SrcFileTime  : "Thu Nov 29 09:27:14 2007"                                |
| Generated by CCDGEN_2.5.5A on Thu Sep 25 09:52:55 2014                   |
|           !!DO NOT MODIFY!!DO NOT MODIFY!!DO NOT MODIFY!!                |
+--------------------------------------------------------------------------+
*/

/* PRAGMAS
 * PREFIX                 : SN
 * COMPATIBILITY_DEFINES  : NO
 * ALWAYS_ENUM_IN_VAL_FILE: YES
 * ENABLE_GROUP: NO
 * CAPITALIZE_TYPENAME: NO
 */


#ifndef P_8010_135_SN_SAP_VAL
#define P_8010_135_SN_SAP_VAL


#define CDG_ENTER__P_8010_135_SN_SAP_VAL

#define CDG_ENTER__FILENAME _P_8010_135_SN_SAP_VAL
#define CDG_ENTER__P_8010_135_SN_SAP_VAL__FILE_TYPE CDGINC
#define CDG_ENTER__P_8010_135_SN_SAP_VAL__LAST_MODIFIED _2004_06_08
#define CDG_ENTER__P_8010_135_SN_SAP_VAL__ID_AND_VERSION _8010_135_04_012

#define CDG_ENTER__P_8010_135_SN_SAP_VAL__SRC_FILE_TIME _Thu_Nov_29_09_27_14_2007

#include "CDG_ENTER.h"

#undef CDG_ENTER__P_8010_135_SN_SAP_VAL

#undef CDG_ENTER__FILENAME

#include "p_8010_137_nas_include.val"   /* Access values independent from the corresponding h-file. */

#include "p_8010_152_ps_include.val"   /* Access values independent from the corresponding h-file. */

#include "p_8010_153_cause_include.val"   /* Access values independent from the corresponding h-file. */


/*
 * Enum to value table VAL_establish
 * CCDGEN:WriteEnum_Count==28
 */
#ifndef __T_SN_VAL_establish__
#define __T_SN_VAL_establish__
typedef enum
{
  SN_ACTIVE_ESTABLISHMENT        = 0x0,           /* SNDCP shall send LL_ESTABLISH_REQ */
  SN_PASSIVE_ESTABLISHMENT       = 0x1            /* SNDCP shall wait for LL_ESTABLISH_IND */
}T_SN_VAL_establish;
#endif

/*
 * user defined constants
 */
#define SN_MAX_UL_PDU                  (0xff)     
#define SN_SIZE_NSAPI                  (0x10)     

#include "CDG_LEAVE.h"


#endif