FreeCalypso > hg > fc-magnetite
view cdg3/cdginc-conservative/p_8010_157_upm_sap.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | c15047b3d00d |
| children |
line wrap: on
line source
/* +--------------------------------------------------------------------------+ | PROJECT : PROTOCOL STACK | | FILE : p_8010_157_upm_sap.h | | SOURCE : "sap\8010_157_upm_sap.pdf" | | LastModified : "2004-01-19" | | IdAndVersion : "8010.157.04.003" | | SrcFileTime : "Thu Nov 29 09:29:28 2007" | | Generated by CCDGEN_2.5.5A on Thu Sep 25 09:52:55 2014 | | !!DO NOT MODIFY!!DO NOT MODIFY!!DO NOT MODIFY!! | +--------------------------------------------------------------------------+ */ /* PRAGMAS * PREFIX : UPM * COMPATIBILITY_DEFINES : NO * ALWAYS_ENUM_IN_VAL_FILE: YES * ENABLE_GROUP: NO * CAPITALIZE_TYPENAME: NO */ #ifndef P_8010_157_UPM_SAP_H #define P_8010_157_UPM_SAP_H #define CDG_ENTER__P_8010_157_UPM_SAP_H #define CDG_ENTER__FILENAME _P_8010_157_UPM_SAP_H #define CDG_ENTER__P_8010_157_UPM_SAP_H__FILE_TYPE CDGINC #define CDG_ENTER__P_8010_157_UPM_SAP_H__LAST_MODIFIED _2004_01_19 #define CDG_ENTER__P_8010_157_UPM_SAP_H__ID_AND_VERSION _8010_157_04_003 #define CDG_ENTER__P_8010_157_UPM_SAP_H__SRC_FILE_TIME _Thu_Nov_29_09_29_28_2007 #include "CDG_ENTER.h" #undef CDG_ENTER__P_8010_157_UPM_SAP_H #undef CDG_ENTER__FILENAME #include "p_8010_157_upm_sap.val" #include "p_8010_137_nas_include.h" /* * End of substructure section, begin of primitive definition section */ #ifndef __T_UPM_DTI_REQ__ #define __T_UPM_DTI_REQ__ /* * * CCDGEN:WriteStruct_Count==1390 */ typedef struct { U8 nsapi; /*< 0: 1> T_NAS_nsapi, network layer service access point identifier */ U8 dti_conn; /*< 1: 1> T_NAS_dti_conn, DTI connect */ U8 dti_direction; /*< 2: 1> T_NAS_dti_direction, direction of DTI connection */ U8 _align0; /*< 3: 1> alignment */ U32 dti_linkid; /*< 4: 4> DTI link identifier */ T_NAS_dti_neighbor dti_neighbor; /*< 8: 8> DTI neighbor entity name (type defined in "p_8010_137_nas_include.h") */ } T_UPM_DTI_REQ; #endif #ifndef __T_UPM_DTI_CNF__ #define __T_UPM_DTI_CNF__ /* * * CCDGEN:WriteStruct_Count==1391 */ typedef struct { U32 dti_linkid; /*< 0: 4> DTI link identifier */ U8 dti_conn; /*< 4: 1> T_NAS_dti_conn, DTI connect */ U8 _align0; /*< 5: 1> alignment */ U8 _align1; /*< 6: 1> alignment */ U8 _align2; /*< 7: 1> alignment */ } T_UPM_DTI_CNF; #endif #ifndef __T_UPM_COUNT_REQ__ #define __T_UPM_COUNT_REQ__ /* * * CCDGEN:WriteStruct_Count==1392 */ typedef struct { U8 nsapi; /*< 0: 1> T_NAS_nsapi, network layer service access point identifier */ U8 reset; /*< 1: 1> T_NAS_reset, reset flag */ U8 _align0; /*< 2: 1> alignment */ U8 _align1; /*< 3: 1> alignment */ } T_UPM_COUNT_REQ; #endif #ifndef __T_UPM_COUNT_CNF__ #define __T_UPM_COUNT_CNF__ /* * * CCDGEN:WriteStruct_Count==1393 */ typedef struct { U8 nsapi; /*< 0: 1> T_NAS_nsapi, network layer service access point identifier */ U8 _align0; /*< 1: 1> alignment */ U8 _align1; /*< 2: 1> alignment */ U8 _align2; /*< 3: 1> alignment */ U32 octets_uplink; /*< 4: 4> octets uplink */ U32 octets_downlink; /*< 8: 4> octets downlink */ U32 packets_uplink; /*< 12: 4> packets uplink */ U32 packets_downlink; /*< 16: 4> packets downlink */ } T_UPM_COUNT_CNF; #endif #include "CDG_LEAVE.h" #endif