FreeCalypso > hg > fc-magnetite
view cdg3/cdginc-conservative/p_dcm.val @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 22 Jul 2018 06:04:49 +0000 |
parents | c15047b3d00d |
children |
line wrap: on
line source
/* +--------------------------------------------------------------------------+ | PROJECT : PROTOCOL STACK | | FILE : p_dcm.val | | SOURCE : "sap\dcm.pdf" | | LastModified : "2003-09-03" | | IdAndVersion : "8462.101.03.001" | | SrcFileTime : "Thu Nov 29 09:39:32 2007" | | Generated by CCDGEN_2.5.5A on Thu Sep 25 09:52:55 2014 | | !!DO NOT MODIFY!!DO NOT MODIFY!!DO NOT MODIFY!! | +--------------------------------------------------------------------------+ */ /* PRAGMAS * PREFIX : NONE * COMPATIBILITY_DEFINES : NO (require PREFIX) * ALWAYS_ENUM_IN_VAL_FILE: NO * ENABLE_GROUP: NO * CAPITALIZE_TYPENAME: NO */ #ifndef P_DCM_VAL #define P_DCM_VAL #define CDG_ENTER__P_DCM_VAL #define CDG_ENTER__FILENAME _P_DCM_VAL #define CDG_ENTER__P_DCM_VAL__FILE_TYPE CDGINC #define CDG_ENTER__P_DCM_VAL__LAST_MODIFIED _2003_09_03 #define CDG_ENTER__P_DCM_VAL__ID_AND_VERSION _8462_101_03_001 #define CDG_ENTER__P_DCM_VAL__SRC_FILE_TIME _Thu_Nov_29_09_39_32_2007 #include "CDG_ENTER.h" #undef CDG_ENTER__P_DCM_VAL #undef CDG_ENTER__FILENAME /* * Value constants for VAL_bearer_select */ #define DCM_SOCK_BEARER_ANY (0x1) /* DCM will decide which connection type to be used */ #define DCM_SOCK_BEARER_GPRS (0x2) /* Use a GPRS context as bearer, DCM will decide which GPRS settings to be used */ #define DCM_SOCK_BEARER_GSM (0x3) /* Use GSM data connection as bearer DCM will decide which GSM settings to be used */ #define DCM_SOCK_BEARER_USE_PROFILE (0x4) /* Use a specific data account for this connection */ #define DCM_SOCK_BEARER_AS_SPECIFIED (0x5) /* Use the data account information which is which is delivered within this signal */ /* * Value constants for VAL_authtype */ #define DCM_SOCK_AUTH_PAP (0x1) /* PAP authentification protocol */ #define DCM_SOCK_AUTH_CHAP (0x2) /* CHAP authentification protocol !!! NOT SUPPORTED */ #define DCM_SOCK_AUTH_NO (0x3) /* No authentication */ /* * Value constants for VAL_result */ #define DCM_RET_OK (0x0) /* The action has been performed successfully. */ #define DCM_RET_NOT_READY (0x1) /* The command can not be processed now. */ #define DCM_RET_ALREADY_ACTIVATED (0x2) /* Connection refused because already actuvated. */ #define DCM_RET_UNKNOWN_EVENT (0x3) /* Unknown receipt event. */ #define DCM_RET_INVALID_PARAMETER (0x4) /* A parameter is wrong. */ #define DCM_RET_CMD_PENDING (0x5) /* There is a pending command yet. */ #define DCM_RET_PS_CONN_BROKEN (0x6) /* Loose of bearer connection. */ /* * user defined constants */ #define CDCM_APN_MAX_LEN (0x64) #define CDCM_PHONE_NR_LEN (0x54) #define CDCM_PDP_MAX_LEN (0x14) #define CDCM_GATE_MAX_LEN (0x14) #define CDCM_USER_MAX_LEN (0x19) #define CDCM_PASSWORD_MAX_LEN (0x19) #define CDCM_DNS_MAX_LEN (0x14) #include "CDG_LEAVE.h" #endif