FreeCalypso > hg > fc-magnetite
view cdg3/cdginc-conservative/p_gsim.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | c15047b3d00d |
| children |
line wrap: on
line source
/* +--------------------------------------------------------------------------+ | PROJECT : PROTOCOL STACK | | FILE : p_gsim.h | | SOURCE : "sap\gsim.pdf" | | LastModified : "2003-02-04" | | IdAndVersion : "8441.113.99.004" | | SrcFileTime : "Thu Nov 29 09:43:12 2007" | | Generated by CCDGEN_2.5.5A on Thu Sep 25 09:52:55 2014 | | !!DO NOT MODIFY!!DO NOT MODIFY!!DO NOT MODIFY!! | +--------------------------------------------------------------------------+ */ /* PRAGMAS * PREFIX : NONE * COMPATIBILITY_DEFINES : NO (require PREFIX) * ALWAYS_ENUM_IN_VAL_FILE: NO * ENABLE_GROUP: NO * CAPITALIZE_TYPENAME: NO */ #ifndef P_GSIM_H #define P_GSIM_H #define CDG_ENTER__P_GSIM_H #define CDG_ENTER__FILENAME _P_GSIM_H #define CDG_ENTER__P_GSIM_H__FILE_TYPE CDGINC #define CDG_ENTER__P_GSIM_H__LAST_MODIFIED _2003_02_04 #define CDG_ENTER__P_GSIM_H__ID_AND_VERSION _8441_113_99_004 #define CDG_ENTER__P_GSIM_H__SRC_FILE_TIME _Thu_Nov_29_09_43_12_2007 #include "CDG_ENTER.h" #undef CDG_ENTER__P_GSIM_H #undef CDG_ENTER__FILENAME #include "p_gsim.val" #ifndef __T_imsi_field__ #define __T_imsi_field__ /* * international mobile subscriber identity * CCDGEN:WriteStruct_Count==1693 */ typedef struct { U8 c_field; /*< 0: 1> length of imsi */ U8 field[MAX_IMSI]; /*< 1: 9> imsi */ U8 _align0; /*< 10: 1> alignment */ U8 _align1; /*< 11: 1> alignment */ } T_imsi_field; #endif /* * End of substructure section, begin of primitive definition section */ #ifndef __T_GSIM_UPDATE_REQ__ #define __T_GSIM_UPDATE_REQ__ /* * * CCDGEN:WriteStruct_Count==1694 */ typedef struct { U8 sim_gprs_invalid; /*< 0: 1> SIM invalid for GPRS service */ U8 gu; /*< 1: 1> GPRS update status */ U8 _align0; /*< 2: 1> alignment */ U8 _align1; /*< 3: 1> alignment */ U32 ptmsi; /*< 4: 4> packet temporary mobile subscriber identity */ U8 ptmsi_signature_flag; /*< 8: 1> P-TMSI Signature flag */ U8 rai[7]; /*< 9: 7> routing_area information */ } T_GSIM_UPDATE_REQ; #endif #ifndef __T_GSIM_STORE_KC_REQ__ #define __T_GSIM_STORE_KC_REQ__ /* * * CCDGEN:WriteStruct_Count==1695 */ typedef struct { U8 gsim_kc[8]; /*< 0: 8> GPRS ciphering key */ U8 gsim_cksn; /*< 8: 1> GPRS ciphering key sequence number */ U8 _align0; /*< 9: 1> alignment */ U8 _align1; /*< 10: 1> alignment */ U8 _align2; /*< 11: 1> alignment */ } T_GSIM_STORE_KC_REQ; #endif #ifndef __T_GSIM_INSERTED_IND__ #define __T_GSIM_INSERTED_IND__ /* * * CCDGEN:WriteStruct_Count==1696 */ typedef struct { U8 sim_gprs_invalid; /*< 0: 1> SIM invalid for GPRS service */ U8 gu; /*< 1: 1> GPRS update status */ U8 rai[7]; /*< 2: 7> routing_area information */ U8 _align0; /*< 9: 1> alignment */ U8 _align1; /*< 10: 1> alignment */ U8 _align2; /*< 11: 1> alignment */ U32 ptmsi; /*< 12: 4> packet temporary mobile subscriber identity */ U32 tmsi; /*< 16: 4> temporary mobile subscriber identity */ T_imsi_field imsi_field; /*< 20: 12> international mobile subscriber identity */ U8 gsim_kc[8]; /*< 32: 8> GPRS ciphering key */ U8 gsim_cksn; /*< 40: 1> GPRS ciphering key sequence number */ U8 _align3; /*< 41: 1> alignment */ U16 acc_contr_class; /*< 42: 2> Access Control Class */ } T_GSIM_INSERTED_IND; #endif #ifndef __T_GSIM_REMOVED_IND__ #define __T_GSIM_REMOVED_IND__ /* * * CCDGEN:WriteStruct_Count==1697 */ typedef struct { U8 dummy; /*< 0: 1> no parameters */ } T_GSIM_REMOVED_IND; #endif #ifndef __T_GSIM_AUTHENTICATION_REQ__ #define __T_GSIM_AUTHENTICATION_REQ__ /* * * CCDGEN:WriteStruct_Count==1698 */ typedef struct { U8 rand[SIZE_RAND]; /*< 0: 16> authentication parameter rand */ U8 gsim_cksn; /*< 16: 1> GPRS ciphering key sequence number */ U8 _align0; /*< 17: 1> alignment */ U8 _align1; /*< 18: 1> alignment */ U8 _align2; /*< 19: 1> alignment */ } T_GSIM_AUTHENTICATION_REQ; #endif #ifndef __T_GSIM_AUTHENTICATION_CNF__ #define __T_GSIM_AUTHENTICATION_CNF__ /* * * CCDGEN:WriteStruct_Count==1699 */ typedef struct { U8 sres[SIZE_SRES]; /*< 0: 4> authentication parameter Sres */ U8 gsim_kc[SIZE_KC]; /*< 4: 8> GPRS ciphering key */ } T_GSIM_AUTHENTICATION_CNF; #endif #include "CDG_LEAVE.h" #endif