FreeCalypso > hg > fc-magnetite

view cdg3/cdginc-conservative/p_mdl.val @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents c15047b3d00d
children
line wrap: on
line source

/*
+--------------------------------------------------------------------------+
| PROJECT : PROTOCOL STACK                                                 |
| FILE    : p_mdl.val                                                      |
| SOURCE  : "sap\mdl.pdf"                                                  |
| LastModified : "2002-04-19"                                              |
| IdAndVersion : "6147.111.97.101"                                         |
| SrcFileTime  : "Thu Nov 29 09:45:46 2007"                                |
| Generated by CCDGEN_2.5.5A on Thu Sep 25 09:52:55 2014                   |
|           !!DO NOT MODIFY!!DO NOT MODIFY!!DO NOT MODIFY!!                |
+--------------------------------------------------------------------------+
*/

/* PRAGMAS
 * PREFIX                 : NONE
 * COMPATIBILITY_DEFINES  : NO (require PREFIX)
 * ALWAYS_ENUM_IN_VAL_FILE: NO
 * ENABLE_GROUP: NO
 * CAPITALIZE_TYPENAME: NO
 */


#ifndef P_MDL_VAL
#define P_MDL_VAL


#define CDG_ENTER__P_MDL_VAL

#define CDG_ENTER__FILENAME _P_MDL_VAL
#define CDG_ENTER__P_MDL_VAL__FILE_TYPE CDGINC
#define CDG_ENTER__P_MDL_VAL__LAST_MODIFIED _2002_04_19
#define CDG_ENTER__P_MDL_VAL__ID_AND_VERSION _6147_111_97_101

#define CDG_ENTER__P_MDL_VAL__SRC_FILE_TIME _Thu_Nov_29_09_45_46_2007

#include "CDG_ENTER.h"

#undef CDG_ENTER__P_MDL_VAL

#undef CDG_ENTER__FILENAME


/*
 * Value constants for VAL_ch_type
 */
#define CH_TYPE_SACCH                  (0x0)      /* SACCH                          */
#define CH_TYPE_SDCCH                  (0x1)      /* SDCCH                          */
#define CH_TYPE_FACCH                  (0x2)      /* FACCH                          */
#define CH_TYPE_BCCH                   (0x3)      /* BCCH                           */
#define CH_TYPE_CCCH                   (0x4)      /* CCCH                           */
#define CH_TYPE_RACH                   (0x5)      /* RACH                           */
#define CH_TYPE_NBR_CEL_BCCH           (0x6)      /* Neighbour Cell BCCH            */

/*
 * Value constants for VAL_sapi
 */
#define SAPI_0                         (0x0)      /* SAPI 0                         */
#define SAPI_3                         (0x3)      /* SAPI 3                         */

/*
 * Value constants for VAL_cs
 */
#define CS_T200_EXP                    (0x0)      /* T200 expired (N200 + 1 times)  */
#define CS_REEST_REQ                   (0x1)      /* re-establishment request       */
#define CS_UNSOL_UA_RESP               (0x2)      /* unsolicited UA response        */
#define CS_UNSOL_DM_RESP               (0x3)      /* unsolicited DM response        */
#define CS_UNSOL_DM_RESP_MULT_FRM      (0x4)      /* unsolicited DM response, multiple frame established state */
#define CS_UNSOL_SUP_RESP              (0x5)      /* unsolicited supervisory response */
#define CS_SEQ_ERR                     (0x6)      /* sequence error                 */
#define CS_UFRM_W_INC_PARA             (0x7)      /* U frame with incorrect parameters */
#define CS_SFRM_W_INC_PARA             (0x8)      /* S frame with incorrect parameters */
#define CS_IFRM_W_INC_MBIT             (0x9)      /* I frame with incorrect use of M bit */
#define CS_IFRM_W_INC_LEN              (0xa)      /* I frame with incorrect length  */
#define CS_FRM_NOT_IMPL                (0xb)      /* frame not implemented          */
#define CS_SABM_MULT_FRM               (0xc)      /* SABM command, multiple frame established state */
#define CS_SABM_NO_INFO                (0xd)      /* SABM command with information field not allowed in this state */
#define CS_NR_SEQ_ERR                  (0xe)      /* sequence error, perform abnormal release */

#include "CDG_LEAVE.h"


#endif