FreeCalypso > hg > fc-magnetite
view cdg3/cdginc-conservative/p_mmi.val @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 22 Jul 2018 06:04:49 +0000 |
parents | c15047b3d00d |
children |
line wrap: on
line source
/* +--------------------------------------------------------------------------+ | PROJECT : PROTOCOL STACK | | FILE : p_mmi.val | | SOURCE : "sap\mmi.pdf" | | LastModified : "2004-08-20" | | IdAndVersion : "6147.113.97.103" | | SrcFileTime : "Thu Nov 29 09:46:32 2007" | | Generated by CCDGEN_2.5.5A on Thu Sep 25 09:52:55 2014 | | !!DO NOT MODIFY!!DO NOT MODIFY!!DO NOT MODIFY!! | +--------------------------------------------------------------------------+ */ /* PRAGMAS * PREFIX : NONE * COMPATIBILITY_DEFINES : NO (require PREFIX) * ALWAYS_ENUM_IN_VAL_FILE: NO * ENABLE_GROUP: NO * CAPITALIZE_TYPENAME: NO */ #ifndef P_MMI_VAL #define P_MMI_VAL #define CDG_ENTER__P_MMI_VAL #define CDG_ENTER__FILENAME _P_MMI_VAL #define CDG_ENTER__P_MMI_VAL__FILE_TYPE CDGINC #define CDG_ENTER__P_MMI_VAL__LAST_MODIFIED _2004_08_20 #define CDG_ENTER__P_MMI_VAL__ID_AND_VERSION _6147_113_97_103 #define CDG_ENTER__P_MMI_VAL__SRC_FILE_TIME _Thu_Nov_29_09_46_32_2007 #include "CDG_ENTER.h" #undef CDG_ENTER__P_MMI_VAL #undef CDG_ENTER__FILENAME /* * Value constants for VAL_control */ #define CTL_NORMAL (0x0) /* normal operation */ #define CTL_HIDDEN (0x1) /* hidden attribut (used for cursor control) */ /* * Value constants for VAL_content */ #define CON_TEXT (0x1) /* sdu contains text */ #define CON_CURSOR (0x2) /* positioning the cursor */ /* * Value constants for VAL_call_tone */ #define CT_RING (0x0) /* ringing tone */ #define CT_AUTH_NUM_UNOBTAIN (0x10) /* authentication or number unobtainable */ #define CT_BUSY (0x11) /* busy tone */ #define CT_CONGESTION (0x12) /* congestion tone */ #define CT_CALL_DROPPED (0x13) /* call dropped */ #define CT_RADIO_ACK (0x14) /* radio acknowledge */ #define CT_CALL_WAIT (0x15) /* call waiting */ #define DTMF_0 (0x16) /* digit 0 */ #define DTMF_1 (0x17) /* digit 1 */ #define DTMF_2 (0x18) /* digit 2 */ #define DTMF_3 (0x19) /* digit 3 */ #define DTMF_4 (0x1a) /* digit 4 */ #define DTMF_5 (0x1b) /* digit 5 */ #define DTMF_6 (0x1c) /* digit 6 */ #define DTMF_7 (0x1d) /* digit 7 */ #define DTMF_8 (0x1e) /* digit 8 */ #define DTMF_9 (0x1f) /* digit 9 */ #define DTMF_A (0x20) /* character A */ #define DTMF_B (0x21) /* character B */ #define DTMF_C (0x22) /* character C */ #define DTMF_D (0x23) /* character D */ #define DTMF_STAR (0x24) /* character * */ #define DTMF_HASH (0x25) /* character # */ #define CT_KEYBEEP (0x26) /* Keybeep */ #define CT_RINGING (0x27) /* ringing tone */ /* * Value constants for VAL_key_stat */ #define KEY_STAT_PRS (0x0) /* pressed */ #define KEY_STAT_REL (0x1) /* released */ /* * Value constants for VAL_mute_stat */ #define MUTE_STAT_OFF (0x0) /* audio path is not muted */ #define MUTE_STAT_ON (0x1) /* audio path is muted */ /* * Value constants for VAL_speech_stat */ #define SPEECH_STAT_OFF (0x0) /* audio path switched off */ #define SPEECH_STAT_ON (0x1) /* audio path switched on */ /* * Value constants for VAL_tone_stat */ #define TONE_SWT_OFF (0x0) /* switch off */ #define TONE_SWT_ON_SINGLE (0x1) /* switch on one time */ #define TONE_SWT_ON_PERIODIC (0x2) /* switch on periodically */ #define TONE_SWT_ON_SILENT (0x3) /* switch on silent */ /* * Value constants for VAL_mode */ #define INDICATION_SINGLE (0x0) /* one single request */ #define INDICATION_ON_CHANGE (0x1) /* new indication after intervall change */ #define INDICATION_PERIODIC (0x2) /* new indication after time period */ #define INDICATION_OFF (0x3) /* no further indications */ /* * Value constants for VAL_modus */ #define CBCH_ACCEPT (0x0) /* accept msg_id and dcs_id */ #define CBCH_IGNORE (0x1) /* ignore msg_id and dcs_id */ #define CBCH_HOMEZONE (0x2) /* Request homezone message after cell reseletion */ #define MMI_CBCH_STOP (0xff) /* stop cbch reading */ /* * Value constants for VAL_ids_mode */ #define IDS_SPEECH (0x0) /* Speech mode */ #define IDS_T_DATA (0x1) /* Transparent Data */ #define IDS_T_FAX (0x2) /* Transparent Fax */ #define IDS_NT_DATA (0x5) /* Non-Transparent Data */ #define IDS_NT_FAX (0x6) /* Non-Transparent Fax */ /* * Value constants for VAL_vocoder_state */ #define VOCODER_DISABLE (0x0) /* Enable the vocoder */ #define VOCODER_ENABLE (0x1) /* Disable the vocoder */ /* * user defined constants */ #define CBCH_MSG_LEN (0x58) #define MAX_SDU_LEN (0x1) #define MAX_IDENTS (0x14) #define MAX_IDENTS_SAT (0xf) #define MAX_RPD_MSG_LEN (0x78) #include "CDG_LEAVE.h" #endif