view cdg3/cdginc-conservative/p_ppp.val @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents c15047b3d00d
children
line wrap: on
line source

/*
+--------------------------------------------------------------------------+
| PROJECT : PROTOCOL STACK                                                 |
| FILE    : p_ppp.val                                                      |
| SOURCE  : "sap\ppp.pdf"                                                  |
| LastModified : "2002-10-21"                                              |
| IdAndVersion : "8441.116.99.016"                                         |
| SrcFileTime  : "Thu Nov 29 09:51:00 2007"                                |
| Generated by CCDGEN_2.5.5A on Thu Sep 25 09:52:55 2014                   |
|           !!DO NOT MODIFY!!DO NOT MODIFY!!DO NOT MODIFY!!                |
+--------------------------------------------------------------------------+
*/

/* PRAGMAS
 * PREFIX                 : NONE
 * COMPATIBILITY_DEFINES  : NO (require PREFIX)
 * ALWAYS_ENUM_IN_VAL_FILE: NO
 * ENABLE_GROUP: NO
 * CAPITALIZE_TYPENAME: NO
 */


#ifndef P_PPP_VAL
#define P_PPP_VAL


#define CDG_ENTER__P_PPP_VAL

#define CDG_ENTER__FILENAME _P_PPP_VAL
#define CDG_ENTER__P_PPP_VAL__FILE_TYPE CDGINC
#define CDG_ENTER__P_PPP_VAL__LAST_MODIFIED _2002_10_21
#define CDG_ENTER__P_PPP_VAL__ID_AND_VERSION _8441_116_99_016

#define CDG_ENTER__P_PPP_VAL__SRC_FILE_TIME _Thu_Nov_29_09_51_00_2007

#include "CDG_ENTER.h"

#undef CDG_ENTER__P_PPP_VAL

#undef CDG_ENTER__FILENAME


/*
 * Value constants for VAL_mru
 */
#define PPP_MRU_DEFAULT                (0x5dc)    /* default value for mru          */

/*
 * Value constants for VAL_ap
 */
#define PPP_AP_NO                      (0x0)      /* no authentication              */
#define PPP_AP_PAP                     (0x1)      /* password authentication protocol */
#define PPP_AP_CHAP                    (0x2)      /* challenge handshake authentication protocol */
#define PPP_AP_AUTO                    (0x3)      /* automatic authentication       */

/*
 * Value constants for VAL_accm
 */
#define PPP_ACCM_DEFAULT               (0xffffffff)/* default value for accm         */
#define PPP_ACCM_OFF                   (0x0)      /* disable control character mapping */

/*
 * Value constants for VAL_rt
 */
#define PPP_RT_DEFAULT                 (0x3)      /* default value for restart timer */

/*
 * Value constants for VAL_mc
 */
#define PPP_MC_DEFAULT                 (0xa)      /* default value for max configure */

/*
 * Value constants for VAL_mt
 */
#define PPP_MT_DEFAULT                 (0x2)      /* default value for max terminate */

/*
 * Value constants for VAL_mf
 */
#define PPP_MF_DEFAULT                 (0x5)      /* default value for max failure  */

/*
 * Value constants for VAL_ppp_cause
 */
#define PPP_TERM_OK_MMI                (0xcf01)   /* successful terminated (MMI initiated) */
#define PPP_TERM_OK_PEER               (0xcf02)   /* successful terminated (PPP peer initiated) */
#define PPP_TERM_NO_RESPONSE           (0xcf03)   /* no response from the PPP peer  */
#define PPP_TERM_LOOP_BACK             (0xcf04)   /* looped-back link detected      */
#define PPP_TERM_LCP_NOT_CONVERGE      (0xcf05)   /* LCP configuration is not converging */
#define PPP_TERM_IPCP_NOT_CONVERGE     (0xcf06)   /* IPCP configuration is not converging */
#define PPP_TERM_IPCP_NOT_STARTED      (0xcf07)   /* PPP peer did not start IPCP configuration */
#define PPP_TERM_NO_CHANNEL            (0xcf08)   /* can not open communication channels */
#define PPP_TERM_PROT_REJ_UNEXPECTED   (0xcf09)   /* unexpected Protocol Rejection from PPP peer */
#define PPP_TERM_USE_AUTHED_FAILED     (0xcf0a)   /* user authentication failed     */
#define PPP_TERM_PROT_ERROR_UNSPEC     (0xcf0b)   /* unspecified protocol error     */

/*
 * Value constants for VAL_ppp_hc
 */
#define PPP_HC_OFF                     (0x0)      /* no header compression          */
#define PPP_HC_VJ                      (0x1)      /* Van Jacobson header compression */

/*
 * Value constants for VAL_ip
 */
#define PPP_IP_DYNAMIC                 (0x0)      /* dynaminc IP address negotiation */

/*
 * Value constants for VAL_dns1
 */
#define PPP_DNS1_DYNAMIC               (0x0)      /* dynaminc primary DNS server address negotiation */

/*
 * Value constants for VAL_dns2
 */
#define PPP_DNS2_DYNAMIC               (0x0)      /* dynaminc secondary DNS server address negotiation */

/*
 * Value constants for VAL_mode
 */
#define PPP_CLIENT                     (0x0)      /* start PPP as client            */
#define PPP_SERVER                     (0x1)      /* start PPP as server            */
#define PPP_TRANSPARENT                (0x2)      /* start PPP in transparent mode  */

/*
 * Value constants for VAL_lower_layer
 */
#define PPP_LOWER_LAYER_DOWN           (0x0)      /* lower layer is not available   */
#define PPP_LOWER_LAYER_UP             (0x1)      /* lower layer is available       */

/*
 * Value constants for VAL_connected_direction
 */
#define PPP_DTI_CONN_PEER              (0x0)      /* DTI channel is connected to Peer Layer */
#define PPP_DTI_CONN_PROT              (0x1)      /* DTI channel is connected to Protocol Layer */

/*
 * user defined constants
 */
#define PPP_LOGIN_NAME_LENGTH          (0x21)     
#define PPP_PASSWORD_LENGTH            (0x19)     
#define PPP_ORIGINATING_ENTITY         (0xf)      

#include "CDG_LEAVE.h"


#endif