FreeCalypso > hg > fc-magnetite
view cdg3/cdginc-conservative/p_tb.val @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 22 Jul 2018 06:04:49 +0000 |
parents | c15047b3d00d |
children |
line wrap: on
line source
/* +--------------------------------------------------------------------------+ | PROJECT : PROTOCOL STACK | | FILE : p_tb.val | | SOURCE : "sap\tb.pdf" | | LastModified : "2001-07-17" | | IdAndVersion : "8441.112.01.002" | | SrcFileTime : "Thu Nov 29 09:54:48 2007" | | Generated by CCDGEN_2.5.5A on Thu Sep 25 09:52:55 2014 | | !!DO NOT MODIFY!!DO NOT MODIFY!!DO NOT MODIFY!! | +--------------------------------------------------------------------------+ */ /* PRAGMAS * PREFIX : NONE * COMPATIBILITY_DEFINES : NO (require PREFIX) * ALWAYS_ENUM_IN_VAL_FILE: NO * ENABLE_GROUP: NO * CAPITALIZE_TYPENAME: NO */ #ifndef P_TB_VAL #define P_TB_VAL #define CDG_ENTER__P_TB_VAL #define CDG_ENTER__FILENAME _P_TB_VAL #define CDG_ENTER__P_TB_VAL__FILE_TYPE CDGINC #define CDG_ENTER__P_TB_VAL__LAST_MODIFIED _2001_07_17 #define CDG_ENTER__P_TB_VAL__ID_AND_VERSION _8441_112_01_002 #define CDG_ENTER__P_TB_VAL__SRC_FILE_TIME _Thu_Nov_29_09_54_48_2007 #include "CDG_ENTER.h" #undef CDG_ENTER__P_TB_VAL #undef CDG_ENTER__FILENAME /* * Value constants for VAL_arfcn */ #define TB_INVALID_ARFCN (0xffff) /* Used to mark a channel number entry as invalid. */ /* * user defined constants */ #define TB_BA_LIST_SIZE (0x21) #include "CDG_LEAVE.h" #endif