FreeCalypso > hg > fc-magnetite
view cdg3/cdginc-conservative/p_udp.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 22 Jul 2018 06:04:49 +0000 |
parents | c15047b3d00d |
children |
line wrap: on
line source
/* +--------------------------------------------------------------------------+ | PROJECT : PROTOCOL STACK | | FILE : p_udp.h | | SOURCE : "sap\udp.pdf" | | LastModified : "2003-08-26" | | IdAndVersion : "8444.100.00.006" | | SrcFileTime : "Thu Nov 29 09:56:22 2007" | | Generated by CCDGEN_2.5.5A on Thu Sep 25 09:52:55 2014 | | !!DO NOT MODIFY!!DO NOT MODIFY!!DO NOT MODIFY!! | +--------------------------------------------------------------------------+ */ /* PRAGMAS * PREFIX : NONE * COMPATIBILITY_DEFINES : NO (require PREFIX) * ALWAYS_ENUM_IN_VAL_FILE: NO * ENABLE_GROUP: NO * CAPITALIZE_TYPENAME: NO */ #ifndef P_UDP_H #define P_UDP_H #define CDG_ENTER__P_UDP_H #define CDG_ENTER__FILENAME _P_UDP_H #define CDG_ENTER__P_UDP_H__FILE_TYPE CDGINC #define CDG_ENTER__P_UDP_H__LAST_MODIFIED _2003_08_26 #define CDG_ENTER__P_UDP_H__ID_AND_VERSION _8444_100_00_006 #define CDG_ENTER__P_UDP_H__SRC_FILE_TIME _Thu_Nov_29_09_56_22_2007 #include "CDG_ENTER.h" #undef CDG_ENTER__P_UDP_H #undef CDG_ENTER__FILENAME #include "p_udp.val" /* * End of substructure section, begin of primitive definition section */ #ifndef __T_UDP_BIND_REQ__ #define __T_UDP_BIND_REQ__ /* * * CCDGEN:WriteStruct_Count==3145 */ typedef struct { U16 port; /*< 0: 2> destination port */ U8 _align0; /*< 2: 1> alignment */ U8 _align1; /*< 3: 1> alignment */ } T_UDP_BIND_REQ; #endif #ifndef __T_UDP_BIND_CNF__ #define __T_UDP_BIND_CNF__ /* * * CCDGEN:WriteStruct_Count==3146 */ typedef struct { U16 port; /*< 0: 2> destination port */ U8 err; /*< 2: 1> error code */ U8 _align0; /*< 3: 1> alignment */ } T_UDP_BIND_CNF; #endif #ifndef __T_UDP_CLOSEPORT_REQ__ #define __T_UDP_CLOSEPORT_REQ__ /* * * CCDGEN:WriteStruct_Count==3147 */ typedef struct { U16 port; /*< 0: 2> destination port */ U8 _align0; /*< 2: 1> alignment */ U8 _align1; /*< 3: 1> alignment */ } T_UDP_CLOSEPORT_REQ; #endif #ifndef __T_UDP_CLOSEPORT_CNF__ #define __T_UDP_CLOSEPORT_CNF__ /* * * CCDGEN:WriteStruct_Count==3148 */ typedef struct { U8 dummy; /*< 0: 1> no parameters */ } T_UDP_CLOSEPORT_CNF; #endif #ifndef __T_UDP_ERROR_IND__ #define __T_UDP_ERROR_IND__ /* * * CCDGEN:WriteStruct_Count==3149 */ typedef struct { U16 dst_port; /*< 0: 2> destination port */ U16 src_port; /*< 2: 2> source port */ U8 err_msg; /*< 4: 1> error message */ U8 _align0; /*< 5: 1> alignment */ U8 _align1; /*< 6: 1> alignment */ U8 _align2; /*< 7: 1> alignment */ U32 src_addr; /*< 8: 4> source address */ U32 dst_addr; /*< 12: 4> destination address */ } T_UDP_ERROR_IND; #endif #ifndef __T_UDP_ERROR_RES__ #define __T_UDP_ERROR_RES__ /* * * CCDGEN:WriteStruct_Count==3150 */ typedef struct { U8 dummy; /*< 0: 1> no parameters */ } T_UDP_ERROR_RES; #endif #ifndef __T_UDP_SHUTDOWN_IND__ #define __T_UDP_SHUTDOWN_IND__ /* * * CCDGEN:WriteStruct_Count==3151 */ typedef struct { U8 dummy; /*< 0: 1> no parameters */ } T_UDP_SHUTDOWN_IND; #endif #ifndef __T_UDP_SHUTDOWN_RES__ #define __T_UDP_SHUTDOWN_RES__ /* * * CCDGEN:WriteStruct_Count==3152 */ typedef struct { U8 dummy; /*< 0: 1> no parameters */ } T_UDP_SHUTDOWN_RES; #endif #include "CDG_LEAVE.h" #endif