FreeCalypso > hg > fc-magnetite

view cdg3/sap/gmmsms.pdf @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents c15047b3d00d
children
line wrap: on
line source

;********************************************************************************
;*** File           : gmmsms.pdf
;*** Creation       : Wed Mar 11 09:58:06 CST 2009
;*** XSLT Processor : Apache Software Foundation / http://xml.apache.org/xalan-j / supports XSLT-Ver: 1
;*** Copyright      : (c) Texas Instruments AG, Berlin Germany 2002
;********************************************************************************
;*** Document Type  : Service Access Point Specification
;*** Document Name  : gmmsms
;*** Document No.   : 8441.105.99.001
;*** Document Date  : 1999-06-22
;*** Document Status: BEING_PROCESSED
;*** Document Author: ANS
;********************************************************************************



PRAGMA 	SRC_FILE_TIME 	"Thu Nov 29 09:42:44 2007"
PRAGMA 	LAST_MODIFIED 	"1999-06-22"
PRAGMA 	ID_AND_VERSION 	"8441.105.99.001"






VALTAB 	VAL_reg_state
VAL 	0 	SMS_RS_DEREGISTERED 	"GMM context for SMS is removed"
VAL 	1 	SMS_RS_REGISTERED 	"GMM context for SMS is built"

VALTAB 	VAL_radio_priority_level
VAL 	DEF 	 	"priority level 4"
VAL 	1 	SMS_RP_LEVEL_1 	"priority level 1"
VAL 	2 	SMS_RP_LEVEL_2 	"priority level 2??????????"
VAL 	3 	SMS_RP_LEVEL_3 	"priority level 3"
VAL 	4 	SMS_RP_LEVEL_4 	"priority level 4"




VAR 	reg_state 	"Registration state" 	B

VAL 	@p_gmmsms - VAL_reg_state@ 	

VAR 	radio_priority_level 	"Radio priority level" 	B

VAL 	@p_gmmsms - VAL_radio_priority_level@ 	







; GMMSMS_REG_STATE_REQ 	0x2300
; GMMSMS_REG_STATE_CNF 	0x6300



PRIM 	GMMSMS_REG_STATE_REQ 	0x2300
{
}






PRIM 	GMMSMS_REG_STATE_CNF 	0x6300
{
 	reg_state 	 ; Registration state
 	radio_priority_level 	 ; Radio priority level
}