FreeCalypso > hg > fc-magnetite

view cdg3/sap/ip.pdf @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents c15047b3d00d
children
line wrap: on
line source

;********************************************************************************
;*** File           : ip.pdf
;*** Creation       : Wed Mar 11 09:58:12 CST 2009
;*** XSLT Processor : Apache Software Foundation / http://xml.apache.org/xalan-j / supports XSLT-Ver: 1
;*** Copyright      : (c) Texas Instruments AG, Berlin Germany 2002
;********************************************************************************
;*** Document Type  : Service Access Point Specification
;*** Document Name  : ip
;*** Document No.   : 8444.101.00.006
;*** Document Date  : 2003-08-30
;*** Document Status: BEING_PROCESSED
;*** Document Author: Jacek
;********************************************************************************



PRAGMA 	SRC_FILE_TIME 	"Thu Nov 29 09:43:40 2007"
PRAGMA 	LAST_MODIFIED 	"2003-08-30"
PRAGMA 	ID_AND_VERSION 	"8444.101.00.006"






VALTAB 	VAL_err
VAL 	0 	IP_ADDR_NOERROR 	"no error"
VAL 	1 	IP_ADDR_NOROUTE 	"no route to destination"

VALTAB 	VAL_trans_prot
VAL 	6 	TCP_PROTOCOL 	"TCP protocol"
VAL 	17 	UDP_PROTOCOL 	"UDP protocol"
VAL 	16 	RAW_PROTOCOL 	"Chaos"




VAR 	dst_addr 	"destination address" 	L


VAR 	src_addr 	"source address" 	L


VAR 	err 	"error code" 	B

VAL 	@p_ip - VAL_err@ 	

VAR 	trans_prot 	"transport protocol" 	B

VAL 	@p_ip - VAL_trans_prot@ 	







; IP_ADDR_REQ 	0x3900
; IP_ADDR_CNF 	0x7900



PRIM 	IP_ADDR_REQ 	0x3900
{
 	dst_addr 	 ; destination address
 	trans_prot 	 ; transport protocol
}






PRIM 	IP_ADDR_CNF 	0x7900
{
 	src_addr 	 ; source  address
 	err 	 ; error code
 	trans_prot 	 ; transport protocol
}