FreeCalypso > hg > fc-magnetite

view cdg3/sap/mnlc.pdf @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents c15047b3d00d
children
line wrap: on
line source

;********************************************************************************
;*** File           : mnlc.pdf
;*** Creation       : Wed Mar 11 09:58:25 CST 2009
;*** XSLT Processor : Apache Software Foundation / http://xml.apache.org/xalan-j / supports XSLT-Ver: 1
;*** Copyright      : (c) Texas Instruments AG, Berlin Germany 2002
;********************************************************************************
;*** Document Type  : Service Access Point Specification
;*** Document Name  : mnlc
;*** Document No.   : 8443.104.02.003
;*** Document Date  : 2002-10-25
;*** Document Status: SUBMITTED
;*** Document Author: TML
;********************************************************************************



PRAGMA 	SRC_FILE_TIME 	"Thu Nov 29 09:48:12 2007"
PRAGMA 	LAST_MODIFIED 	"2002-10-25"
PRAGMA 	ID_AND_VERSION 	"8443.104.02.003"



CONST 	L_MAX_CALLED_BCD_NO_LENGTH 	10 	; Max Bcd number length (digits)
CONST 	CURSOR_SMS_TEXT_140 	140 	; Position SMS Message



VALTAB 	VAL_data_valid
VAL 	0 	DATA_VALID 	""
VAL 	1 	DATA_INVALID 	""




VAR 	reference 	"Reference" 	S


VAR 	bcd 	"Bcd Number" 	B


VAR 	data_valid 	"Cursor Data Valid" 	B

VAL 	@p_mnlc - VAL_data_valid@ 	

VAR 	number_length 	"Number of decimal digits in the Bcd number" 	B


VAR 	sms_text 	"SMS text" 	B





COMP 	called_party_bcd_num 	 "called Party Bcd number"
{
 	number_length 	 ; Number Length
 	bcd 	[L_MAX_CALLED_BCD_NO_LENGTH] 	 ; Bcd Number
}






; MNLC_SMS_MEAS_REQ 	0x80000044
; MNLC_SMS_MEAS_CNF 	0x80004044



PRIM 	MNLC_SMS_MEAS_REQ 	0x80000044
{
 	reference 	 ; Reference SMS request
 	called_party_bcd_num 	 ; Called Bcd Number
}






PRIM 	MNLC_SMS_MEAS_CNF 	0x80004044
{
 	reference 	 ; Reference SMS request
 	data_valid 	 ; Cursor Data Valid
 	sms_text 	[CURSOR_SMS_TEXT_140] 	 ; Cursor SMS
}