src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.

#ifndef __L1SW_CFG__
#define __L1SW_CFG__
#define AMR 1
#define CUST 0
#define DCO_ALGO 0
#define IDS 1
#define L1_12NEIGH 1
#define L1_EOTD 0
#define L1_EOTD_QBIT_ACC 0
#define L1_GPRS 1
#define L1_GTT 0
#define L1_MIDI 0
#define L1_VOICE_MEMO_AMR 1
#define MELODY_E2 1
#define OP_L1_STANDALONE 0
#define OP_RIV_AUDIO 1
#define ORDER2_TX_TEMP_CAL 1
#define RAZ_VULSWITCH_REGAUDIO 0
#define SECURITY 0
#define SPEECH_RECO 1
#define TESTMODE 1
#define TRACE_TYPE 4
#define VCXO_ALGO 1
#endif /* __L1SW_CFG__ */