FreeCalypso > hg > fc-magnetite
view components/bmi-tcs3 @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 22 Jul 2018 06:04:49 +0000 |
parents | ad7f986afae3 |
children |
line wrap: on
line source
# Building bmi.lib from TCS3/LoCosto source CFLAGS="-me -mt -o -pw2 -x -mw" CPPFLAGS= make_version bmi cfile_plain bmi_version.c # Defines CPPFLAGS=-DMMI_HOMEZONE_ENABLED CPPFLAGS="$CPPFLAGS -DFF_MMI_SAT_ICON" CPPFLAGS="$CPPFLAGS -DFF_MMI_SMS_DYNAMIC" if [ "$GPRS" = 1 ] then CPPFLAGS="$CPPFLAGS -DMMI_GPRS_ENABLED" fi CPPFLAGS="$CPPFLAGS -DMMI_EM_ENABLED" CPPFLAGS="$CPPFLAGS -DNO_ASCIIZ" case "$UI_CONFIG" in bigcolor) CPPFLAGS="$CPPFLAGS -DCOLOURDISPLAY" CPPFLAGS="$CPPFLAGS -DLSCREEN" ;; bigbw) CPPFLAGS="$CPPFLAGS -DLSCREEN" ;; 84x48) ;; *) echo "Error: UI_CONFIG=$UI_CONFIG setting not understood" 1>&2 exit 1 esac CPPFLAGS="$CPPFLAGS -DINT_PHONEBOOK" CPPFLAGS="$CPPFLAGS -DNEW_EDITOR" CPPFLAGS="$CPPFLAGS -DTRGT_G23" CPPFLAGS="$CPPFLAGS -DAUS_CONDAT_TYPE_PORTING" CPPFLAGS="$CPPFLAGS -DCCDTABLES_EXTERN" CPPFLAGS="$CPPFLAGS -DOPTION_MULTITHREAD" CPPFLAGS="$CPPFLAGS -DNEW_FRAME" CPPFLAGS="$CPPFLAGS -DNEW_ENTITY" CPPFLAGS="$CPPFLAGS -D_TARGET_" CPPFLAGS="$CPPFLAGS -DSHARED_VSI" CPPFLAGS="$CPPFLAGS -DALR" CPPFLAGS="$CPPFLAGS -DFF_HOMEZONE" CPPFLAGS="$CPPFLAGS -DFF_MMI_SAT_ICON" CPPFLAGS="$CPPFLAGS -DFF_MMI_SMS_DYNAMIC" CPPFLAGS="$CPPFLAGS -DFF_CPHS" CPPFLAGS="$CPPFLAGS -D_TMS470" CPPFLAGS="$CPPFLAGS -DUART" CPPFLAGS="$CPPFLAGS -DFF_ATI" CPPFLAGS="$CPPFLAGS -DPHONEBOOK_EXTENSION" if [ "$GPRS" = 1 ] then CPPFLAGS="$CPPFLAGS -DGPRS" fi CPPFLAGS="$CPPFLAGS -DFF_EM_MODE" CPPFLAGS="$CPPFLAGS -DMMI=2" CPPFLAGS="$CPPFLAGS -DMFW" CPPFLAGS="$CPPFLAGS -DAT_INTERPRETER" CPPFLAGS="$CPPFLAGS -DUSE_L1FD_FUNC_INTERFACE" if [ "$SRVC" != 0 ] then CPPFLAGS="$CPPFLAGS -DFAX_AND_DATA" if [ "$SRVC" = 1 ] then CPPFLAGS="$CPPFLAGS -DFF_FAX" fi CPPFLAGS="$CPPFLAGS -DUSE_L2FD_FUNC_INTERFACE" fi CPPFLAGS="$CPPFLAGS -DSRVC=$SRVC" CPPFLAGS="$CPPFLAGS -DNWARN" CPPFLAGS="$CPPFLAGS -DSIM_TOOLKIT" CPPFLAGS="$CPPFLAGS -DCHIPSET=$CHIPSET" CPPFLAGS="$CPPFLAGS -DBOARD=41" # Includes CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/inc" CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc" CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/include" CPPFLAGS="$CPPFLAGS -I../../$CDGINC" CPPFLAGS="$CPPFLAGS -I$SRC/ui3/bmi" CPPFLAGS="$CPPFLAGS -I$SRC/ui3/mfw" CPPFLAGS="$CPPFLAGS -I$SRC/$ACI/aci" CPPFLAGS="$CPPFLAGS -I$SRC/$ACI/aci_dti_mng" CPPFLAGS="$CPPFLAGS -I$SRC/$ACI/ksd" CPPFLAGS="$CPPFLAGS -I$SRC/ui3/atb" CPPFLAGS="$CPPFLAGS -I.." CPPFLAGS="$CPPFLAGS -I../config" CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera" CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app" CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core" CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/abb" CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/armio" CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/clkm" CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/conf" CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dma" CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dsp_dwnld" CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/inth" CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/memif" CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/rhea" CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/security" CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/spi" CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/timer" CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/uart" CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/ulpd" CPPFLAGS="$CPPFLAGS -I$SRC/cs/system" CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/include" CPPFLAGS="$CPPFLAGS -I$SRC/cs/services" # Source modules SRCDIR=$SRC/ui3/bmi cfile_str2ind $SRCDIR/mmiCall.c cfile_str2ind $SRCDIR/mmiResources.c cfile_str2ind $SRCDIR/mmiBlkLangDB.c cfile_str2ind $SRCDIR/mmiBlkManager.c cfile_str2ind $SRCDIR/mmiBlkResources.c cfile_str2ind $SRCDIR/mmiBookCallDetailsWindow.c cfile_str2ind $SRCDIR/mmiBookCallListWindow.c cfile_str2ind $SRCDIR/mmiBookController.c cfile_str2ind $SRCDIR/mmiBookDetailsWindow.c cfile_str2ind $SRCDIR/mmiBookMenuWindow.c cfile_str2ind $SRCDIR/mmiBookPhonebook.c cfile_str2ind $SRCDIR/mmiBookSDNWindow.c cfile_str2ind $SRCDIR/mmiBookSearchWindow.c cfile_str2ind $SRCDIR/mmiBookServices.c cfile_str2ind $SRCDIR/mmiBookShared.c cfile_str2ind $SRCDIR/mmiBookUtils.c cfile_str2ind $SRCDIR/mmiDialogs.c cfile_str2ind $SRCDIR/mmiDummy.c cfile_str2ind $SRCDIR/mmiIcons.c cfile_str2ind $SRCDIR/mmiIdle.c cfile_str2ind $SRCDIR/mmiLists.c cfile_str2ind $SRCDIR/mmiMain.c cfile_str2ind $SRCDIR/mmiMenu.c cfile_str2ind $SRCDIR/mmiMmi.c cfile_str2ind $SRCDIR/mmiNetwork.c cfile_str2ind $SRCDIR/mmiPins.c cfile_str2ind $SRCDIR/mmiServices.c cfile_str2ind $SRCDIR/mmiSettings.c cfile_str2ind $SRCDIR/mmiSmsBroadcast.c cfile_str2ind $SRCDIR/mmiSounds.c cfile_str2ind $SRCDIR/mmiSmsIdle.c cfile_str2ind $SRCDIR/mmiSmsMenu.c cfile_str2ind $SRCDIR/mmiSmsSend.c cfile_str2ind $SRCDIR/mmiSmsRead.c cfile_str2ind $SRCDIR/mmiSoftKeys.c cfile_str2ind $SRCDIR/mmiStart.c cfile_str2ind $SRCDIR/mmiTimeDate.c cfile_str2ind $SRCDIR/mmiUserData.c cfile_str2ind $SRCDIR/mmiSatCall.c cfile_str2ind $SRCDIR/mmiSatInfo.c cfile_str2ind $SRCDIR/mmiSatInput.c cfile_str2ind $SRCDIR/mmiSatMenu.c cfile_str2ind $SRCDIR/mmiSimToolkit.c cfile_str2ind $SRCDIR/mmiVoiceMemo.c cfile_str2ind $SRCDIR/mmiCalculatorMain.c cfile_str2ind $SRCDIR/mmiMelody_data.c cfile_str2ind $SRCDIR/mmiTimers.c cfile_str2ind $SRCDIR/mmiAoc.c cfile_str2ind $SRCDIR/mmiCPHS.c cfile_str2ind $SRCDIR/mmiBand.c cfile_str2ind $SRCDIR/mmiSatClassE.c if [ "$GPRS" = 1 ] then cfile_str2ind $SRCDIR/mmiGprs.c fi cfile_str2ind $SRCDIR/mmiHomezone.c cfile_str2ind $SRCDIR/AUICalcEditor.c cfile_str2ind $SRCDIR/AUIEditor.c cfile_str2ind $SRCDIR/AUIPinEditor.c cfile_str2ind $SRCDIR/AUISymbol.c cfile_str2ind $SRCDIR/AUITextEntry.c cfile_str2ind $SRCDIR/mmiEm.c