FreeCalypso > hg > fc-magnetite
view configs/classic @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | 2c61607bb3e3 |
| children | 4a242cfb9bc5 |
line wrap: on
line source
# This configuration reproduces the original TCS211 pdt_2091 build, # using almost all of the original blobs from Sotovik. scripts/config-headers.sh gprs 2091 CONDAT=condat2 GPF=gpf2 CDGINC=cdg211/cdginc CDGPRIM=cdg211/prim ACI=aci2 export CONDAT GPF CDGINC CDGPRIM ACI GPRS=1 MMI=0 SRVC=1 export GPRS MMI SRVC blob_lib_std ccddata # ACI libs build_lib aci classic build_lib aciext classic build_lib aci_dti_mng classic build_lib atiext classic build_lib comlib build_lib config_gprs_fl build_lib config_gprs_ir lib_link_magic '(BSS_LIBS (.bss) CONST_LIBS (.text, .const))' # G23M protocol stack libs blob_lib_std alr blob_lib_std cc blob_lib_std cci blob_lib_std cci_ir lib_link_magic '(BSS_LIBS (.bss) CONST_LIBS (.text, .const))' blob_lib_std dl blob_lib_std dti blob_lib_std fad blob_lib_std gmm blob_lib_std grlc blob_lib_std grlc_ir lib_link_magic '(BSS_LIBS (.bss) CONST_LIBS (.text, .const))' blob_lib_std grr blob_lib_std l1_pei blob_lib_std l2r blob_lib_std llc blob_lib_std mm blob_lib_std ra blob_lib_std rlp blob_lib_std rr blob_lib_std sim_b_lib blob_lib_std sm blob_lib_std sms blob_lib_std sndcp blob_lib_std ss blob_lib_std t30 blob_lib_std uart_b_lib blob_lib_std ppp blob_lib_std ppp_ir lib_link_magic '(BSS_LIBS (.bss) CONST_LIBS (.text, .const))' # Condat drivers build_lib gdi # GPF blob_lib_gpf ccd_na7_db blob_lib_gpf frame_na7_db_fl blob_lib_custom blobs/patches/frame_na7_db_ir-systrace.lib frame_na7_db_ir lib_link_magic '(BSS_LIBS (.bss) CONST_LIBS (.text, .const))' blob_lib_gpf misc_na7_db_fl blob_lib_gpf misc_na7_db_ir lib_link_magic '(BSS_LIBS (.bss) CONST_LIBS (.text, .const))' blob_lib_gpf osx_na7_db lib_link_magic '(BSS_LIBS (.bss) CONST_LIBS (.text, .const))' blob_lib_gpf tif_na7_db_fl blob_lib_gpf tif_na7_db_ir lib_link_magic '(BSS_LIBS (.bss) CONST_LIBS (.text, .const))' # core drivers build_lib drivers_flash # Layer 1 blob_lib_custom "$TPUDRV_blob" tpudrv lib_link_magic '(BSS_LIBS (.bss) CONST_LIBS (.text, .const))' blob_lib_std l1_ext lib_link_magic '(BSS_LIBS (.l1s_global))' blob_lib_std l1_int lib_link_magic '(BSS_LIBS (.bss) CONST_LIBS (.text, .const))' blob_lib_std l1_custom_ext blob_lib_std l1_custom_int lib_link_magic '(BSS_LIBS (.bss) CONST_LIBS (.text, .const))' build_lib riviera_core_flash build_lib riviera_cust_flash # services build_lib atp build_lib audio build_lib audio_bgd build_lib cst build_lib dar build_lib dar_gbl_var lib_link_magic '(BSS_DAR_LIB (.bss))' build_lib etm build_lib lls build_lib mks # app drivers build_lib abb build_lib buzzer build_lib ffs build_lib ffs_drv build_lib ffs_pcm build_lib kpd build_lib lcc build_lib power build_lib rtc_drv build_lib sim_drv build_lib spi_drv build_lib uart_drv # eyesores blob_lib_custom "$MAIN_blob" main build_lib bootloader lib_link_magic '(CONST_BOOT_LIB (.const, .text, .text:v$3) BSS_BOOT_LIB (.bss))' # Nucleus and TI's compiler stuff blob_lib_os nucleus_flash_nodbg blob_lib_os nucleus_int_ram_nodbg lib_link_magic '(BSS_LIBS (.bss) CONST_LIBS (.text, .const))' blob_lib_os rts16le_flash blob_lib_os rts16le_int_ram lib_link_magic '(BSS_LIBS (.bss))' str2ind_blobs_used=1