src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.

[board.cfg]

BOARD 41
DSAMPLE_FULL_COLOR var

[chipset.cfg]

ANLG_FAM 2
ANLG_PG 0
CHIPSET var

[debug.cfg]

TI_NUC_MONITOR 0
TI_PROFILER 0

[dio.cfg]

DIOIL_CONFIG 0

[ffs.cfg]

TARGET 1
_RVF 1

[l1sw.cfg]

AMR var
CUST 0
DCO_ALGO 0
IDS var
L1_12NEIGH 1
L1_EOTD 0
L1_EOTD_QBIT_ACC 0
L1_GPRS var
L1_GTT 0
L1_MIDI 0
L1_VOICE_MEMO_AMR var
MELODY_E2 var
OP_L1_STANDALONE 0
OP_RIV_AUDIO 1
ORDER2_TX_TEMP_CAL 1
RAZ_VULSWITCH_REGAUDIO 0
SECURITY 0
SPEECH_RECO var
TESTMODE 1
TRACE_TYPE 4
VCXO_ALGO 1

[r2d.cfg]

R2D_ASM 0
R2D_LCD_TEST 0

[rf.cfg]

RF var
RF_FAM var
RF_PA var
RF_PG var

[rv.cfg]

RVTOOL 0
TEST 0
_GSM 1

[swconfig.cfg]

ALR 1
BT 0
DP 0
DWNLD 1
GSMLITE 0
L1_DYN_DSP_DWNLD var
LONG_JUMP 3
MOVE_IN_INTERNAL_RAM 1
OP_WCP 0
PMODE var
RVDATA_INTERNALRAM 0
SRVC var
TR_BAUD_CONFIG var
WCP_PROF 0

[sys.cfg]

DSP var
STD 6

[trace.cfg]

LAYER_DBG 0xFFFFFFFF
TRACE_LEVEL_FILTER 5