FreeCalypso > hg > fc-magnetite

view scripts/mk-component.sh @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 87347425b11f
children 41b6a18ffa0b
line wrap: on
line source

#!/bin/sh

if [ $# -lt 1 -o $# -gt 2 ]
then
	echo "usage: $0 component-lib [flavor]" 1>&2
	exit 1
fi

LIBNAME="$1"

if [ -n "$2" ]
then
	recipe_file="components/$1-$2"
else
	recipe_file="components/$1"
fi

if [ ! -f "$recipe_file" ]
then
	echo "Error: $recipe_file not found" 1>&2
	exit 1
fi

if [ -z "$BUILD_DIR" ]
then
	echo "Error: BUILD_DIR= must be passed via environment" 1>&2
	exit 1
fi

set -e

mkdir -p $BUILD_DIR/$LIBNAME

# beginning of the Makefile
echo "all:	$LIBNAME.lib" > $BUILD_DIR/$LIBNAME/Makefile
echo >> $BUILD_DIR/$LIBNAME/Makefile

# shell functions to be used in the recipes

make_version() {
	case $# in
	    1)
		echo "$1_version.c:" >> $BUILD_DIR/$LIBNAME/Makefile
		echo "	../../scripts/make-version.sh $1 > $1_version.c" \
			>> $BUILD_DIR/$LIBNAME/Makefile
		;;
	    2)
		echo "$2_version.c:" >> $BUILD_DIR/$LIBNAME/Makefile
		echo "	../../scripts/make-version.sh $1 > $2_version.c" \
			>> $BUILD_DIR/$LIBNAME/Makefile
		;;
	    *)
		echo "Error: make_version takes 1 or 2 arguments" 1>&2
		exit 1
		;;
	esac
	echo >> $BUILD_DIR/$LIBNAME/Makefile
}

asm_file() {
	if [ $# != 1 ]
	then
		echo "Error: asm_file takes 1 argument" 1>&2
		exit 1
	fi
	objname=`basename "$1" .s`.obj
	helpers/makeline dep $objname "$1" >> $BUILD_DIR/$LIBNAME/Makefile
	helpers/makeline cmd ../../toolwrap/asm470 ${ASMFLAGS} "$1" '$@' \
		>> $BUILD_DIR/$LIBNAME/Makefile
	echo >> $BUILD_DIR/$LIBNAME/Makefile
	OBJS="$OBJS $objname"
}

cfile_plain() {
	if [ $# != 1 ]
	then
		echo "Error: cfile_plain takes 1 argument" 1>&2
		exit 1
	fi
	objname=`basename "$1" .c`.obj
	helpers/makeline dep $objname "$1" >> $BUILD_DIR/$LIBNAME/Makefile
	case "$objname" in
		*[A-Z]*)
			helpers/makeline cmd rm -f '$@' \
				>> $BUILD_DIR/$LIBNAME/Makefile
			;;
	esac
	helpers/makeline cmd ../../toolwrap/cl470 -q -c ${CFLAGS} ${CPPFLAGS} \
		"$1" >> $BUILD_DIR/$LIBNAME/Makefile
	case "$objname" in
		*[A-Z]*)
			objname_lc=`echo $objname | tr A-Z a-z`
			helpers/makeline cmd mv $objname_lc $objname \
				>> $BUILD_DIR/$LIBNAME/Makefile
			;;
	esac
	echo >> $BUILD_DIR/$LIBNAME/Makefile
	OBJS="$OBJS $objname"
}

cfile_str2ind() {
	if [ $# != 1 ]
	then
		echo "Error: cfile_str2ind takes 1 argument" 1>&2
		exit 1
	fi
	if [ "$USE_STR2IND" = 1 ]
	then
		objname=`basename "$1" .c`.obj
		pp_name=`echo $1 | sed -e 's/\.c$/.pp/' | tr A-Z a-z`
		pp__name=`echo $1 | sed -e 's/\.c$/.pp_/' | tr A-Z a-z`
		helpers/makeline dep $objname "$1" \
			>> $BUILD_DIR/$LIBNAME/Makefile
		case "$objname" in
			*[A-Z]*)
				helpers/makeline cmd rm -f '$@' \
					>> $BUILD_DIR/$LIBNAME/Makefile
				;;
		esac
		helpers/makeline cmd ../../toolwrap/cl470 -q -po -p? -x \
			${CPPFLAGS} "$1" >> $BUILD_DIR/$LIBNAME/Makefile
		helpers/makeline cmd ../../toolwrap/str2ind -a \
			-t ../str2ind.tab -l ../str2ind.log \
			-f "$pp_name" >> $BUILD_DIR/$LIBNAME/Makefile
		helpers/makeline cmd ../../toolwrap/cl470 -q -c ${CFLAGS} \
			"$pp__name" >> $BUILD_DIR/$LIBNAME/Makefile
		helpers/makeline cmd @rm -f "$pp_name" \
			>> $BUILD_DIR/$LIBNAME/Makefile
		helpers/makeline cmd @rm -f "$pp__name" \
			>> $BUILD_DIR/$LIBNAME/Makefile
		case "$objname" in
			*[A-Z]*)
				objname_lc=`echo $objname | tr A-Z a-z`
				helpers/makeline cmd mv $objname_lc $objname \
					>> $BUILD_DIR/$LIBNAME/Makefile
				;;
		esac
		echo >> $BUILD_DIR/$LIBNAME/Makefile
		OBJS="$OBJS $objname"
	else
		cfile_plain "$1"
	fi
}

# invoke the recipe

SRC=../../src
OBJS=
. "$recipe_file"

# finish the Makefile

helpers/makeline dep $LIBNAME.lib ${OBJS} >> $BUILD_DIR/$LIBNAME/Makefile
echo '	../../toolwrap/ar470 r $@ $^' >> $BUILD_DIR/$LIBNAME/Makefile
echo >> $BUILD_DIR/$LIBNAME/Makefile
echo 'clean:' >> $BUILD_DIR/$LIBNAME/Makefile
echo '	rm -f *.obj *.lib *.c' >> $BUILD_DIR/$LIBNAME/Makefile