FreeCalypso > hg > fc-magnetite
view src/aci2/aci/ati_em.c @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 22 Jul 2018 06:04:49 +0000 |
parents | 93999a60b835 |
children |
line wrap: on
line source
/* +----------------------------------------------------------------------------- | Project : | Modul : +----------------------------------------------------------------------------- | Copyright 2002 Texas Instruments Berlin, AG | All rights reserved. | | This file is confidential and a trade secret of Texas | Instruments Berlin, AG | The receipt of or possession of this file does not convey | any rights to reproduce or disclose its contents or to | manufacture, use, or sell anything it may describe, in | whole, or in part, without the specific written consent of | Texas Instruments Berlin, AG. +----------------------------------------------------------------------------- | Purpose : This module provides the ati interface for the engineering mode. +----------------------------------------------------------------------------- */ #undef DUMMY_ATI_STRINGS #include "aci_all.h" #include "aci_cmh.h" #include "ati_cmd.h" #include "aci_io.h" #include "aci_cmd.h" #include "l4_tim.h" #include "aci_em.h" #include "aci_mem.h" #include "aci_prs.h" #include "aci_lst.h" #include "ati_int.h" #ifdef FF_ATI_BAT #include "typedefs.h" #include "gdd.h" #include "bat.h" #include "ati_bat.h" #endif /*FF_ATI_BAT*/ /*==== EXPORT =====================================================*/ /*==== VARIABLES ==================================================*/ /*==== FUNCTIONS ==================================================*/ /*==== CONSTANTS ==================================================*/ #define EMET_L1 0x0001 #define EMET_ALL 0x00ff /* +------------------------------------------------------------------------------ | Function : setatPercentEM +------------------------------------------------------------------------------ | Description : AT-cmd for the EM infrastructure data | | | Parameters : char *cl | UBYTE srcId | | Return : char * +------------------------------------------------------------------------------ */ GLOBAL T_ATI_RSLT setatPercentEM (char *cl, UBYTE srcId) { T_ACI_RETURN ret = AT_FAIL; T_EM_AT_MODE mode = ACI_NumParmNotPresent; T_EM_AT_TYPE type = ACI_NumParmNotPresent; T_ATI_SRC_PARAMS *src_params = find_element (ati_src_list, srcId, search_ati_src_id); src_params->curAtCmd = AT_CMD_EM; cl = parse (cl, "dd", &mode, &type); if ( (mode NEQ SIN_REP) AND (mode NEQ PCO_REP) ) { cmdCmeError (CME_ERR_OpNotSupp); return ATI_FAIL; } if ( (mode EQ SIN_REP) AND ((type EQ ACI_NumParmNotPresent) OR ((type < EM_AT_SC) AND (type > EM_AT_PDP))) ) { cmdCmeError (CME_ERR_OpNotSupp); return ATI_FAIL; } if ( (mode EQ PCO_REP) AND ((type EQ ACI_NumParmNotPresent) OR (type > EM_AT_PCO_HIGHEST-1)) ) { cmdCmeError (CME_ERR_OpNotSupp); return ATI_FAIL; } if (type EQ ACI_NumParmNotPresent) { type = EM_AT_SC; } srcId_cb = srcId; #ifdef FF_ATI_BAT { T_BAT_cmd_send cmd; T_BAT_cmd_set_percent_em my_bat_set_percent_em; TRACE_FUNCTION("setatPercentEM() calls bat_send() <=== as APPLICATION"); memset(&my_bat_set_percent_em, 0, sizeof(my_bat_set_percent_em)); cmd.ctrl_params = BAT_CMD_SET_PERCENT_EM; cmd.params.ptr_set_percent_em = &my_bat_set_percent_em; my_bat_set_percent_em.mode = mode; my_bat_set_percent_em.sin_type = type; my_bat_set_percent_em.pco_type = type; bat_send(ati_bat_get_client(srcId), &cmd); return ATI_EXCT; /* executing, because response is passed by callback function */ } #else /* OLD FUNCTION BODY */ TRACE_FUNCTION("setatPercentEM()"); ret = sAT_PercentEM(srcId, mode, type); switch(ret) { case AT_CMPL: break; case AT_EXCT: src_params->curAtCmd = AT_CMD_EM; break; case AT_FAIL: cmdCmeError(CME_ERR_Unknown); break; default: cmdCmeError(CME_ERR_Unknown); break; } /* switch */ return (map_aci_2_ati_rslt(ret)); #endif /* no FF_ATI_BAT*/ } /* +------------------------------------------------------------------------------ | Function : setatPercentEMET +------------------------------------------------------------------------------ | Description : AT-cmd for the EM event traces | | | Parameters : char *cl | UBYTE srcId | | Return : char * +------------------------------------------------------------------------------ */ GLOBAL T_ATI_RSLT setatPercentEMET (char *cl, UBYTE srcId) { T_ACI_RETURN ret = AT_EXCT; SHORT type = ACI_NumParmNotPresent; T_ATI_SRC_PARAMS *src_params = find_element (ati_src_list, srcId, search_ati_src_id); TRACE_FUNCTION("setatPercentEMET()"); cl = parse (cl, "d", &type); /* if type is not in range then error*/ if ((type < EMET_L1) OR (type > EMET_ALL)) { cmdCmeError (CME_ERR_OpNotSupp); return ATI_FAIL; } srcId_cb = srcId; ret = sAT_PercentEMET(srcId, (UBYTE)type); switch(ret) { case AT_CMPL: break; case AT_EXCT: src_params->curAtCmd = AT_CMD_EMET; break; case AT_FAIL: cmdCmeError(CME_ERR_Unknown); break; default: cmdCmeError(CME_ERR_Unknown); break; } /* switch */ return (map_aci_2_ati_rslt(ret)); } /* setatPercentEMET */ /* +------------------------------------------------------------------------------ | Function : setatPercentEMETS +------------------------------------------------------------------------------ | Description : AT-cmd for the EM event traces | | | Parameters : char *cl | UBYTE srcId | | Return : char * +------------------------------------------------------------------------------ */ GLOBAL T_ATI_RSLT setatPercentEMETS (char *cl, UBYTE srcId) { T_ACI_RETURN ret = AT_EXCT; SHORT subclass = ACI_NumParmNotPresent; ULONG bitm_h = ACI_NumParmNotPresent; ULONG bitm_l = ACI_NumParmNotPresent; T_ATI_SRC_PARAMS *src_params = find_element (ati_src_list, srcId, search_ati_src_id); TRACE_FUNCTION("setatPercentEMETS()"); cl = parse (cl, "dyy", &subclass, &bitm_h, &bitm_l); if ( (subclass < EM_L1) OR (subclass > EM_SIM) ) { cmdCmeError (CME_ERR_OpNotSupp); return ATI_FAIL; } srcId_cb = srcId; ret = sAT_PercentEMETS(srcId, (UBYTE)subclass, bitm_h, bitm_l); switch(ret) { case AT_CMPL: break; case AT_EXCT: src_params->curAtCmd = AT_CMD_EMETS; break; case AT_FAIL: cmdCmeError(CME_ERR_Unknown); break; default: cmdCmeError(CME_ERR_Unknown); break; } /* switch */ return (map_aci_2_ati_rslt(ret)); } /* setatPercentEMETS */ /*+++++++++++++++++++++++++++++++++++++++++ E O F +++++++++++++++++++++++++++++++++++++++++*/