FreeCalypso > hg > fc-magnetite

view src/aci2/aci/ati_fchg.c @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 09b12bd1b0f2
children 96c1d047b3c6
line wrap: on
line source

/*
 * The non-standard FreeCalypso-added AT commands implemented in this module
 * expose the API of FreeCalypso battery charging driver FCHG.
 */

#ifndef ATI_FCHG_C
#define ATI_FCHG_C

#include "aci_all.h"

#include <ctype.h>
#include <string.h>

#include "aci_cmh.h"
#include "ati_cmd.h"
#include "aci_cmd.h"
#include "aci_io.h"
#include "aci_cmd.h"
#include "l4_tim.h"
#include "line_edit.h"
#include "aci_lst.h"

#include "pcm.h"
#include "audio.h"
#include "aci.h"
#include "rx.h"
#include "pwr.h"
#include "l4_tim.h"

#ifdef GPRS
#ifdef DTI
#include "dti.h"
#include "dti_conn_mng.h"
#include "dti_cntrl_mng.h"
#endif /* DTI */
#include "gaci.h"
#include "gaci_cmh.h"
#include "gaci_cmd.h"
#endif  /* GPRS */

#include "aci_mem.h"
#include "aci_prs.h"

#include "ati_int.h"

#ifndef _SIMULATION_
#include "ffs/ffs.h"
#endif

#ifdef FF_ATI_BAT

#include "typedefs.h"
#include "gdd.h"
#include "bat.h"

#include "ati_bat.h"

#endif /*FF_ATI_BAT*/

#include "rv/rv_defined_swe.h"     // for RVM_FCHG_SWE

#ifdef RVM_FCHG_SWE
#include "fchg/fchg_api.h"

/* AT%CBC - customized alternative to standard AT+CBC */
GLOBAL T_ATI_RSLT atPercentCBC ( char *cl, UBYTE srcId )
{
	struct fchg_user_state fchg;

	TRACE_FUNCTION("atPercentCBC()");
	if (fchg_get_current_state(&fchg) != RV_OK)
		return ATI_FAIL;
	sprintf(g_sa, "%%CBC: %d,%d,%d", fchg.chg_state, fchg.batt_mv,
		fchg.batt_percent);
	io_sendMessage(srcId, g_sa, ATI_NORMAL_OUTPUT);
	return ATI_CMPL;
}

/* AT@CHG - manual control of battery charging */
GLOBAL T_ATI_RSLT atAtCHG ( char *cl, UBYTE srcId )
{
	enum fchg_user_charge_ctrl ctrl;

	TRACE_FUNCTION("atAtCHG()");
	cl = parse(cl, "D", &ctrl);
	if (!cl)
		return ATI_FAIL;
	if (fchg_user_charge_control(ctrl) == RV_OK)
		return ATI_CMPL;
	else
		return ATI_FAIL;
}

#endif /* RVM_FCHG_SWE */

#endif /* ATI_FCHG_C */