FreeCalypso > hg > fc-magnetite

view src/aci2/aci/ati_src_bt.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 93999a60b835
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  
|  Modul   :  J:\g23m-aci\aci\ati_src_bt.h
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  
+----------------------------------------------------------------------------- 
*/ 
#ifndef ATI_SRC_BT_H
#define ATI_SRC_BT_H

EXTERN T_ATI_RESULT_CB      bt_src_result_cb;
EXTERN T_ATI_LINE_STATE_CB  bt_src_line_state_cb;
EXTERN BOOL bt_src_dti_cb( UBYTE srcId, T_DTI_MNG_CB_TYPE result_type );
EXTERN BOOL ati_src_bt_proc_cmd (T_ACI_CMD_REQ_BT *cmd);

EXTERN T_ACI_RETURN bt_src_connect (UBYTE srcId, T_DTI_ENTITY_ID unit);
EXTERN T_ACI_RETURN bt_src_disconnect (UBYTE srcId);

EXTERN T_BTI_ACK io_openPort (T_BTI_PORT_NB port);
EXTERN void io_closePort (T_BTI_PORT_NB port);

EXTERN void bt_enqueue_command(T_BTI_PORT_NB port_nb, UBYTE *output, USHORT output_len, UBYTE type);
EXTERN UBYTE bt_set_output_type(T_ATI_OUTPUT_TYPE t);
#endif /* ATI_SRC_BT_H */