FreeCalypso > hg > fc-magnetite

view src/aci2/aci/cmh_dti.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 93999a60b835
children
line wrap: on
line source

/*
+------------------------------------------------------------------------------
|  File:       cmh_dti.h
+------------------------------------------------------------------------------
|                 Copyright Condat AG 1999-2000, Berlin
|                 All rights reserved.
|
|                 This file is confidential and a trade secret of Condat AG.
|                 The receipt of or possession of this file does not convey
|                 any rights to reproduce or disclose its contents or to
|                 manufacture, use, or sell anything it may describe, in
|                 whole, or in part, without the specific written consent of
|                 Condat AG.
+------------------------------------------------------------------------------
| Purpose:     Definitions for the DTI managment. 
|              
| $Identity:$
+------------------------------------------------------------------------------
*/


#ifndef CMH_DTI_H
#define CMH_DTI_H



/*==== ENUMS =====================================================*/

typedef enum              /* DTI redirection mode */
{
  REDIR_DELETE = 0,
  REDIR_ONCE,
  REDIR_ALWAYS    
} T_ACI_REDIR_MODE;

typedef enum              /* DINF mode */
{
  SHOW_CURR_CHAN_INF = 0,
  SHOW_ALL_CHAN_INF
} T_ACI_DINF_MODE;

typedef enum               /* to map*/
{
  DEV_CPBLTY_CMD = 0,      /* AT cmd capability                    */
  DEV_CPBLTY_SER,          /* serial capability                    */
  DEV_CPBLTY_PKT,          /* packet capability                    */
  DEV_CPBLTY_CMD_SER,      /* AT cmd and serial capability         */
  DEV_CPBLTY_CMD_PKT,      /* AT cmd and packet capability         */
  DEV_CPBLTY_PKT_SER,      /* packet and serial capability         */
  DEV_CPBLTY_CMD_PKT_SER,  /* AT cmd, packet and serial capability */
  DEV_CPBLTY_NONE          /* sentinel for %DINF command           */
} T_CAP_ID;

/*==== STRUCTS =====================================================*/

typedef struct
{
  CHAR     *name;
  T_CAP_ID  id;
} T_CAP_NAME;

/*==== VARIABLE====================================================*/


/*==== EXPORT =====================================================*/


#endif /* CMH_DTI_H */
                 
/*==== EOF =======================================================*/