FreeCalypso > hg > fc-magnetite

view src/aci2/aci/cmh_lc.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 93999a60b835
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  GSM-PS (6147)
|  Modul   :  CMH_LC
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  Definitions for the command handler of the
|             Location Service
+----------------------------------------------------------------------------- 
*/ 

#ifndef CMH_LC_H
#define CMH_LC_H
#endif

#if defined FF_EOTD
/*==== CONSTANTS ==================================================*/


/*==== TYPES ======================================================*/
/* T_LC_NVM_DATA */
/*
 * Caution! An identical definition must be contained in the file
 * ...\lc\lc.h
 */
typedef struct
{
  UBYTE eotd;       /* 0: EOTD detection by RR 1: EOTD assumed */
  UBYTE cps_trace;  /* 0: CPS log not started automatically 1: CPS log started */
  UBYTE periodic;   /* 0: periodic SMS by AT commands only 1: periodic SMS restarted */
  UBYTE sleep;      /* 0: no change of sleep mode 1: sleep switched off */
} T_LC_NVM_DATA;

/*==== PROTOTYPES =================================================*/

EXTERN void cmhLC_posDataReq (char*    clientId, USHORT   lcCallRefId);
EXTERN void cmhSMS_MEASdeliver ( UBYTE *lc_meas_buf);
EXTERN UBYTE lc_callref_init (void);
T_ACI_RETURN lclist_init (void);
/* EXTERN void lclist_deinit (void); */

/*==== EXPORT =====================================================*/

#ifdef CMH_LCS_C
EXTERN UBYTE             v_eotd;
GLOBAL T_LOC_SERV_PARA   locServPrm;  /* list of LC clients */
GLOBAL BOOL location_service_flag;    /* status of feature location service (E-OTD) */
GLOBAL BOOL eotd_periodic_update_flag;/* status of feature Periodic Update (E-OTD) */

GLOBAL T_LOC_MLC_ADDRESS lc_orig_addr;
GLOBAL T_LOC_POS_DATA aci_lc_data;
GLOBAL USHORT used_lc_callref = 1;

#else
EXTERN T_LOC_SERV_PARA   locServPrm;  /* list of LC clients */
EXTERN BOOL location_service_flag;    /* status of feature location service (E-OTD) */
EXTERN BOOL eotd_periodic_update_flag;/* status of feature Periodic Update (E-OTD) */
EXTERN T_LOC_MLC_ADDRESS lc_orig_addr;
EXTERN T_LOC_POS_DATA aci_lc_data;
EXTERN USHORT used_lc_callref;

#endif

/*==== EOF =======================================================*/
#endif